Add some new methods to purple tags

Review Request #3143 — Created April 23, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

* purple_tags_exists is a simplier version of purple_tags_lookup.
* purple_tags_contains makes it easier to find multiple matching tags.

Ran the unit tests under valgrind and had the turtles check in on things too.

Summary ID
Add some new methods to purple tags
* purple_tags_exists is a simplier version of purple_tags_lookup. * purple_tags_contains makes it easier to find multiple matching tags.
e8703f13a9aa8fc1588a380d353067f68e555a9f
Description From Last Updated

Compile warning: In file included from /usr/include/glib-2.0/glib.h:64, from ../libpurple/purpletags.h:30, from ../libpurple/purpletags.c:23: ../libpurple/purpletags.c: In function ‘purple_tags_contains’: /usr/include/glib-2.0/glib/gmessages.h:660:16: warning: returning ‘PurpleTags *’ …

ivanhoeivanhoe
ivanhoe
  1. 
      
  2. libpurple/purpletags.c (Diff revision 1)
     
     
    Show all issues

    Compile warning:

    In file included from /usr/include/glib-2.0/glib.h:64,
                     from ../libpurple/purpletags.h:30,
                     from ../libpurple/purpletags.c:23:
    ../libpurple/purpletags.c: In function ‘purple_tags_contains’:
    /usr/include/glib-2.0/glib/gmessages.h:660:16: warning: returning ‘PurpleTags *’ {aka ‘struct _PurpleTags *’} from a function with return type ‘gboolean’ {aka ‘int’} makes integer from pointer without a ca
    t [-Wint-conversion]
      660 |         return (val); \
          |                ^
    ../libpurple/purpletags.c:405:9: note: in expansion of macro ‘g_return_val_if_fail’
      405 |         g_return_val_if_fail(PURPLE_IS_TAGS(tags), needle);
          |         ^~~~~~~~~~~~~~~~~~~~
    
  3. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed