Update the demo protocol plugin to not depend on conversation names

Review Request #3135 — Created April 16, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

We're starting to phase out conversation names as they don't work well with
modern stuff. So this goes ahead and fixes the not interactions in the demo
protocol.

I also generated the echo message in the send_message_async rather than in the
callback.

Ran the turtles and send some messages to Echo on the demo protocol.

Summary ID
Update the demo protocol plugin to not depend on conversation names
We're starting to phase out conversation names as they don't work well with modern stuff. So this goes ahead and fixes the not interactions in the demo protocol. I also generated the echo message in the send_message_async rather than in the callback.
1415204d66d2e4889adb1ab9fdb4b6c72e02f69f
Description From Last Updated

Not sure if this is within the scope of this RR but opening a conversation in the Demo protocol fails …

ivanhoeivanhoe
ivanhoe
  1. 
      
  2. Show all issues

    Not sure if this is within the scope of this RR but opening a conversation in the Demo protocol fails and a failed assertion is printed to the console:

    purple_conversation_set_title: assertion 'title != NULL' failed
    
    1. yeah that assertion is going to get handled elsewhere. I'm in the process of removing the "name" property from conversations which is what's causing that. That property is marked with G_PARAM_CONSTRUCT which causes it's setter to be called at creation time, and that setting calls purple_conversation_autoset_title that calls purple_conversation_set_title with the value of the name.

      So, once I kill the name property (which is used all over the place) that assert will go away.

  3. 
      
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed