Summary

Update the demo protocol plugin to not depend on conversation names

Review Request #3135 — Created April 16, 2024 and submitted April 18, 2024, 5:43 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

We're starting to phase out conversation names as they don't work well with
modern stuff. So this goes ahead and fixes the not interactions in the demo
protocol.

I also generated the echo message in the send_message_async rather than in the
callback.

Testing Done

Ran the turtles and send some messages to Echo on the demo protocol.

Commits

Summary	ID
Update the demo protocol plugin to not depend on conversation names We're starting to phase out conversation names as they don't work well with modern stuff. So this goes ahead and fixes the not interactions in the demo protocol. I also generated the echo message in the send_message_async rather than in the callback.	1415204d66d2e4889adb1ab9fdb4b6c72e02f69f

Issues

Description	From	Last Updated
Not sure if this is within the scope of this RR but opening a conversation in the Demo protocol fails …	ivanhoe	April 17, 2024, 4:53 p.m.

The issue has been dropped. Show all issues

Not sure if this is within the scope of this RR but opening a conversation in the Demo protocol fails and a failed assertion is printed to the console:

purple_conversation_set_title: assertion 'title != NULL' failed

grim April 16, 2024, 8:30 p.m.

yeah that assertion is going to get handled elsewhere. I'm in the process of removing the "name" property from conversations which is what's causing that. That property is marked with G_PARAM_CONSTRUCT which causes it's setter to be called at creation time, and that setting calls purple_conversation_autoset_title that calls purple_conversation_set_title with the value of the name.

So, once I kill the name property (which is used all over the place) that assert will go away.

Ship it!

```
Ship It!
```

Status:: Completed