Summary

Add the ability to create conversations to PurpleProtocolConversation

Review Request #3045 — Created March 23, 2024 and submitted April 10, 2024, 5:40 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17855

Depends On

Blocks

3055, 3054

Reviewers

Groups

pidgin

People

Description

Add the ability to create conversations to PurpleProtocolConversation

Testing Done

Ran the unit tests under valgrind and had the turtles check on everything as well.

Commits

Summary	ID
Add the ability to create conversations to PurpleProtocolConversation	62ab40b0f152cfd7046e96a39e7b9746821bea7a

Issues

Description	From	Last Updated
Is this transfer full or transfer none? If it doesn't get much re-use, maybe transfer full is good here?	QuLogic	March 29, 2024, 5:31 a.m.
Missing a word here.	QuLogic	March 29, 2024, 5:31 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	c2a9e82334f3275df7600ed891c713c0872167b3
	Add the ability to create conversations to PurpleProtocolConversation	14cde58a2a436f4d1b532c7e5a730385a74c375a

Diff:

Revision 2 (+804)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Change Summary:

Create a failed GTask if create_conversation_async is not implemented.

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	14cde58a2a436f4d1b532c7e5a730385a74c375a
	Add the ability to create conversations to PurpleProtocolConversation	1225bc274c5d24eaf3c428f59efc02a9b6104c69

Diff:

Revision 3 (+862)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Change Summary:

add a purple- prefix to the error domain.

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	1225bc274c5d24eaf3c428f59efc02a9b6104c69
	Add the ability to create conversations to PurpleProtocolConversation	e8e2dd2534b39ebdfcd563675c9a7525136f4e03

Diff:

Revision 4 (+862)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

libpurple/purpleprotocolconversation.h (Diff revision 3)

Show all issues

Is this transfer full or transfer none? If it doesn't get much re-use, maybe transfer full is good here?

libpurple/purpleprotocolconversation.h (Diff revision 3)
Show all issues
```
Missing a word here.
```

Change Summary:

Address issues and rework a bunch of stuff.

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	e8e2dd2534b39ebdfcd563675c9a7525136f4e03
	Add the ability to create conversations to PurpleProtocolConversation	e0bc656b637cee33c6f6eba093f031ac3328e9e5

Diff:

Revision 5 (+886)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Change Summary:

add a helper method to check if the protocol implements everything to create conversations

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	e0bc656b637cee33c6f6eba093f031ac3328e9e5
	Add the ability to create conversations to PurpleProtocolConversation	e69661465c08caa7d7dcf0c65196ad4dd01508c4

Diff:

Revision 6 (+968)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Change Summary:

rename to implements_create_conversation and add unit tests.

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	e69661465c08caa7d7dcf0c65196ad4dd01508c4
	Add the ability to create conversations to PurpleProtocolConversation	69fad25bfb0af88a62c106e0ff030eaccf379042

Diff:

Revision 7 (+1026)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Change Summary:

Fix some warnings in the unit tests

Commits:

	Summary	ID
	Add the ability to create conversations to PurpleProtocolConversation	69fad25bfb0af88a62c106e0ff030eaccf379042
	Add the ability to create conversations to PurpleProtocolConversation	62ab40b0f152cfd7046e96a39e7b9746821bea7a

Diff:

Revision 8 (+1026)

Show changes

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Ship it!

```
Self reviewed
```

Review Board 6.0.2

Add the ability to create conversations to PurpleProtocolConversation

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)