Summary

Create PurpleAuthorizationRequestNotification

Review Request #3035 — Created March 19, 2024 and submitted March 22, 2024, 3:22 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3037~~

Reviewers

Groups

pidgin

People

Description

This is the first discrete notifications objects after /r/3009. This also fixes
an issue in /r/3009 where PurpleNotification was still marked as a final type.

Testing Done

I have a WIP branch for updating the Pidgin side that I used to verify functionality but it has some issues so isn't included here.

Also ran the unit tests under valgrind.

Commits

Summary	ID
Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	5379fc3f3c761a4f5ae1b59a1397dd7f113383de

Issues

Description	From	Last Updated
Use purple_strempty	QuLogic	March 22, 2024, 3:17 a.m.
Incorrect indent.	QuLogic	March 22, 2024, 3:17 a.m.
Oh, and do we need this here?	QuLogic	March 22, 2024, 3:18 a.m.

Change Summary:

Remove the G_DEFINE_FINAL_TYPE change as I'm going to put it in another rr that this one will depend on.

Commits:

	Summary	ID
	Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	12aefb5f90d9cbf202979905e986866926ca7d18
	Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	333fac63699ac964da295131bb5618a34f62b9f7

Diff:

Revision 2 (+912)

Show changes

	libpurple/meson.build
	libpurple/purpleauthorizationrequestnotification.h
	libpurple/purpleauthorizationrequestnotification.c
	libpurple/tests/meson.build
	libpurple/tests/test_authorization_request_notification.c

Depends On:

+	~~3037 - Add a subtitle property to PurpleNotification~~

Change Summary:

rebased

Commits:

	Summary	ID
	Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	333fac63699ac964da295131bb5618a34f62b9f7
	Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	71b17254fbe07773b7138391ea1bf37e19e54842

Diff:

Revision 3 (+912)

Show changes

	libpurple/meson.build
	libpurple/purpleauthorizationrequestnotification.h
	libpurple/purpleauthorizationrequestnotification.c
	libpurple/tests/meson.build
	libpurple/tests/test_authorization_request_notification.c

libpurple/purpleauthorizationrequestnotification.c (Diff revision 3)
Show all issues
```
Use purple_strempty
```
libpurple/purpleauthorizationrequestnotification.c (Diff revision 3)
Show all issues
```
Incorrect indent.
```

libpurple/tests/test_authorization_request_notification.c (Diff revision 3)

Show all issues

Oh, and do we need this here?

grim March 22, 2024, 3:11 a.m.

Yes we're using accounts which current still needs the global protocol manager and status subsystem initialized.

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	71b17254fbe07773b7138391ea1bf37e19e54842
	Create PurpleAuthorizationRequestNotification This is the first discrete notifications objects after /r/3009. This also fixes an issue in /r/3009 where PurpleNotification was still marked as a final type.	5379fc3f3c761a4f5ae1b59a1397dd7f113383de

Diff:

Revision 4 (+912)

Show changes

	libpurple/meson.build
	libpurple/purpleauthorizationrequestnotification.h
	libpurple/purpleauthorizationrequestnotification.c
	libpurple/tests/meson.build
	libpurple/tests/test_authorization_request_notification.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Create PurpleAuthorizationRequestNotification

Information

Reviewers

Change Summary:

Commits:

Diff:

Depends On:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)