Stop saving notification setting on unload

Review Request #3024 — Created March 12, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

When libpurple is shutting down, the settings backend is gone before the plugins (and maybe this should be fixed elsewhere), so all the saved settings leak as they attempt to write to a NULL settings object.

All places in this plugin that change the settings then save them, so there's no need to save on unload.

Ran in valgrind with the plugin enabled, and there were no longer any leaks of settings values from unload at exit.

Summary ID
Stop saving notification setting on unload
9a9863708435e8815aa5071a83223ddf172feb33
grim
  1. Great find!! Thanks!!

  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...