Fix leaks of plugin actions

Review Request #3023 — Created March 12, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

All action groups and action menus leak because the plugin info is created, directly returned, and nothing owns them any more.
Instead, steal the reference in the plugin info setters, so that they are owned by it.

Then clean up a bunch of additional refs that aren't needed.

Ran in valgrind, and no longer saw leaks from notification-sound.c.
Also enabled and disabled that plugin and saw no errors.

Summary ID
Fix leaks of plugin actions
4e47449ee1100d7a1707a0eb6727baca738b77fb
Description From Last Updated

the transfer annotation needs updating on this.

grimgrim

the transfer annotation needs updating on this.

grimgrim
grim
  1. 
      
  2. libpurple/purpleplugininfo.c (Diff revision 1)
     
     

    the transfer annotation needs updating on this.

  3. libpurple/purpleplugininfo.c (Diff revision 1)
     
     

    the transfer annotation needs updating on this.

  4. 
      
QuLogic
grim
  1. Great work, thank you so much!!

  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...