Summary

Fix leaks of plugin actions

Review Request #3023 — Created March 12, 2024 and submitted March 12, 2024, 7:25 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

All action groups and action menus leak because the plugin info is created, directly returned, and nothing owns them any more.
Instead, steal the reference in the plugin info setters, so that they are owned by it.

Then clean up a bunch of additional refs that aren't needed.

Testing Done

Ran in valgrind, and no longer saw leaks from notification-sound.c.
Also enabled and disabled that plugin and saw no errors.

Commits

Summary	ID
Fix leaks of plugin actions	4e47449ee1100d7a1707a0eb6727baca738b77fb

Issues

Description	From	Last Updated
the transfer annotation needs updating on this.	grim	March 12, 2024, 7:24 a.m.
the transfer annotation needs updating on this.	grim	March 12, 2024, 7:24 a.m.

libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
the transfer annotation needs updating on this.
```
libpurple/purpleplugininfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
the transfer annotation needs updating on this.
```

Change Summary:

Fix transfer annotations also.

Commits:

	Summary	ID
	Fix leaks of plugin actions	f2949bbaa56cb968655bfe56c832d54215c7e8ea
	Fix leaks of plugin actions	4e47449ee1100d7a1707a0eb6727baca738b77fb

Diff:

Revision 2 (+38 -20)

Show changes

	libpurple/purpleplugininfo.h
	libpurple/purpleplugininfo.c
	libpurple/plugins/notification-sound/notification-sound.c
	pidgin/pidginpluginsmenu.c

Ship it!

```
Great work, thank you so much!!
```

Status:: Completed