Fix transfer annotation of purple_notification_manager_add

 






 

 


  Review Request #3022
  —
  Created March 12, 2024 and submitted 

 




















 

  

   Information

  





 
 

  QuLogic
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This function either returns immediately (for a double add), or adds a ref

before putting it in the GPtrArray. So it is transfer none, not transfer full.

 








  


 
 

  
Ran ninja turtles and also tested with valgrind.

Also added notifications from the demo protocol in valgrind.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix transfer annotation of purple_notification_manager_add
      
This function either returns immediately (for a double add), or adds a ref
before putting it in the `GPtrArray`. So it is `transfer none`, not `transfer
full`.

     


    		
    d0c707933f42c60e01b8b6bf1d24d9906f87d43f

   



  
 




 













 









 






  

 








 














 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Nice finds! Thank you so much!!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...