Summary

Fix transfer annotation of purple_notification_manager_add

Review Request #3022 — Created March 11, 2024 and submitted March 12, 2024, 3:17 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This function either returns immediately (for a double add), or adds a ref

before putting it in the GPtrArray. So it is transfer none, not transfer full.

Testing Done

Ran ninja turtles and also tested with valgrind.
Also added notifications from the demo protocol in valgrind.

Commits

Summary	ID
Fix transfer annotation of purple_notification_manager_add This function either returns immediately (for a double add), or adds a ref before putting it in the `GPtrArray`. So it is `transfer none`, not `transfer full`.	d0c707933f42c60e01b8b6bf1d24d9906f87d43f

Expand All
Collapse All

Ship it!

```
Nice finds! Thank you so much!!
```

Status:: Completed