Summary

Use PurpleProtocol.can_connect_async in the login process

Review Request #3005 — Created March 2, 2024 and submitted March 19, 2024, 5:54 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Also implement it for all the new protocol plugins.

Testing Done

Attempted connections for the new bonjour, ircv3, and new xmpp accounts and verified them made it past the checks.
Attempted and ircv3 account with a bad DNS name and verified it failed in the can_reach_async functions.
Also ran with the turtles.

Commits

Summary	ID
Use PurpleProtocol.can_connect_async in the login process Also implement it for all the new protocol plugins.	07515d334a46a6ea611c7cc148d66e38a266fc72

Issues

Description	From	Last Updated
If I've understood the "Chained asynchronous operations" example correctly, you may want to check g_task_return_error_if_cancelled first here.	QuLogic	March 19, 2024, 5:52 a.m.
Should be PURPLE_IRCV3_DEFAULT_TLS_PORT, probably.	QuLogic	March 19, 2024, 5:13 a.m.
Not using the async function?	QuLogic	March 19, 2024, 5:20 a.m.
Either capitalize first word, or don't end with period.	QuLogic	March 19, 2024, 5:13 a.m.
create a	QuLogic	March 19, 2024, 5:12 a.m.
Ditto.	QuLogic	March 19, 2024, 5:12 a.m.
Semi-colons, not commas.	QuLogic	March 19, 2024, 5:13 a.m.
Ditto for capitalization/period.	QuLogic	March 19, 2024, 5:13 a.m.

libpurple/protocols/ircv3/purpleircv3protocol.c (Diff revision 1)
Show all issues
```
Should be PURPLE_IRCV3_DEFAULT_TLS_PORT, probably.
```
libpurple/protocols/ircv3/purpleircv3protocol.c (Diff revision 1)
Show all issues
```
Not using the async function?
```
libpurple/protocols/ircv3/purpleircv3protocol.c (Diff revision 1)
Show all issues
```
Either capitalize first word, or don't end with period.
```
libpurple/purpleprotocol.h (Diff revision 1)
Show all issues
```
create a
```
protocols/bonjour/purplebonjourprotocol.c (Diff revision 1)
Show all issues
```
Ditto.
```
protocols/bonjour/purplebonjourprotocol.c (Diff revision 1)
Show all issues
```
Semi-colons, not commas.
```
protocols/xmpp/purplexmppprotocol.c (Diff revision 1)
Show all issues
```
Ditto for capitalization/period.
```

Change Summary:

Rebase and address issues.

Commits:

	Summary	ID
	Use PurpleProtocol.can_connect_async in the login process Also implement it for all the new protocol plugins.	74d27d95609bb7e66ddbb7a7812b753bdfb6a3f9
	Use PurpleProtocol.can_connect_async in the login process Also implement it for all the new protocol plugins.	cbdf8248b19afab7aaabdaf9f9dfe97fa0943df0

Diff:

Revision 2 (+436 -52)

Show changes

	libpurple/purpleaccount.c
	libpurple/purpleprotocol.h
	libpurple/purpleprotocol.c
	libpurple/protocols/ircv3/purpleircv3protocol.c
	protocols/bonjour/purplebonjourprotocol.c
	protocols/xmpp/purplexmppprotocol.c

libpurple/protocols/ircv3/purpleircv3protocol.c (Diff revisions 1 - 2)

Show all issues

If I've understood the "Chained asynchronous operations" example correctly, you may want to check g_task_return_error_if_cancelled first here.

Change Summary:

use g_task_return_error_if_cancelled.

Commits:

	Summary	ID
	Use PurpleProtocol.can_connect_async in the login process Also implement it for all the new protocol plugins.	cbdf8248b19afab7aaabdaf9f9dfe97fa0943df0
	Use PurpleProtocol.can_connect_async in the login process Also implement it for all the new protocol plugins.	07515d334a46a6ea611c7cc148d66e38a266fc72

Diff:

Revision 3 (+450 -52)

Show changes

	libpurple/purpleaccount.c
	libpurple/purpleprotocol.h
	libpurple/purpleprotocol.c
	libpurple/protocols/ircv3/purpleircv3protocol.c
	protocols/bonjour/purplebonjourprotocol.c
	protocols/xmpp/purplexmppprotocol.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Use PurpleProtocol.can_connect_async in the login process

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)