Summary

Replace purple_accounts_restore_statuses with purple_account_manager_set_online

Review Request #3002 — Created March 1, 2024 and submitted March 19, 2024, 6:02 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is a step in replacing the old accounts API. I skipped checking if we have
network connectivity or not, because we need to work that into
purple_account_connect and checking purple_protocol_can_connect_async.

Testing Done

Ran with the turtles.

Commits

Summary	ID
Replace purple_accounts_restore_statuses with purple_account_manager_go_online This is a step is replacing the old accounts API. I skipped checking if we have network connectivity or not, because we need to work that into purple_account_connect and checking purple_protocol_can_connect_async.	1750054e46caa6a0d64514adcccba960e8fa365b

Issues

Description	From	Last Updated
hold up on this, making some more changes	grim	March 5, 2024, 3:20 a.m.
online or offline	QuLogic	March 19, 2024, 5:59 a.m.
This if is redundant since manager->online is a boolean, no?	QuLogic	March 19, 2024, 5:59 a.m.

Show all issues

hold up on this, making some more changes

Change Summary:

Make this a property instead and call disconnect when it is set to false.

Summary:

-	Replace purple_accounts_restore_statuses with purple_account_manager_go_online
+	Replace purple_accounts_restore_statuses with purple_account_manager_set_online

Commits:

	Summary	ID
	Replace purple_accounts_restore_statuses with purple_account_manager_go_online This is a step is replacing the old accounts API. I skipped checking if we have network connectivity or not, because we need to work that into purple_account_connect and checking purple_protocol_can_connect_async.	ddc2dd690c59a56f8face757ae0082435a71204d
	Replace purple_accounts_restore_statuses with purple_account_manager_go_online This is a step is replacing the old accounts API. I skipped checking if we have network connectivity or not, because we need to work that into purple_account_connect and checking purple_protocol_can_connect_async.	1553a0ca5e36c2b05c9360b3c45a3d1a4c8cc0f6

Diff:

Revision 2 (+338 -112)

Show changes

	ChangeLog.API
	finch/libfinch.c
	libpurple/accounts.h
	libpurple/accounts.c
	libpurple/purpleaccountmanager.h
	libpurple/purpleaccountmanager.c
	pidgin/pidginapplication.c

Change Summary:

Fix typo

Description:

~		This is a step is replacing the old accounts API. I skipped checking if we have
	~	This is a step in replacing the old accounts API. I skipped checking if we have
		network connectivity or not, because we need to work that into
		purple_account_connect and checking purple_protocol_can_connect_async.

libpurple/purpleaccountmanager.c (Diff revision 2)
Show all issues
```
online or offline
```

libpurple/purpleaccountmanager.c (Diff revision 2)

Show all issues

This if is redundant since manager->online is a boolean, no?

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Replace purple_accounts_restore_statuses with purple_account_manager_go_online This is a step is replacing the old accounts API. I skipped checking if we have network connectivity or not, because we need to work that into purple_account_connect and checking purple_protocol_can_connect_async.	1553a0ca5e36c2b05c9360b3c45a3d1a4c8cc0f6
	Replace purple_accounts_restore_statuses with purple_account_manager_go_online This is a step is replacing the old accounts API. I skipped checking if we have network connectivity or not, because we need to work that into purple_account_connect and checking purple_protocol_can_connect_async.	1750054e46caa6a0d64514adcccba960e8fa365b

Diff:

Revision 3 (+338 -112)

Show changes

	ChangeLog.API
	finch/libfinch.c
	libpurple/accounts.h
	libpurple/accounts.c
	libpurple/purpleaccountmanager.h
	libpurple/purpleaccountmanager.c
	pidgin/pidginapplication.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Replace purple_accounts_restore_statuses with purple_account_manager_set_online

Information

Reviewers

Change Summary:

Summary:

Commits:

Diff:

Change Summary:

Description:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)