-
-
pidgin/pidgindisplaywindow.c (Diff revision 1) This should really be using the conversation's id because names can and will change. If the protocol isn't setting an
id
for a conversation, the protocol needs to be fixed to do so. -
pidgin/pidgindisplaywindow.c (Diff revision 1) Similar to the above, this needs to use the account id instead of the account name. For example, on IRC my nickname is normally grim, but I can change it to anything else while connected which would then break this.
use a globally unique id when creating new Pidgin::DisplayItem's
Review Request #2980 — Created Feb. 23, 2024 and submitted
Use a globally unique id when creating new
Pidgin::DisplayItem
s as the doc demands and as discussed on discourse
Ran Pidgin and opened a conversation.
Summary | ID |
---|---|
343139e5e7e2c6dc25124f39d3f887b7dba17c25 |
Change Summary:
Use ids instead of names.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+22 -4) |