Summary

use a globally unique id when creating new Pidgin::DisplayItem's

Review Request #2980 — Created Feb. 23, 2024 and submitted Feb. 28, 2024, 6:11 a.m.

Information

Owner

ivanhoe

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2981

Reviewers

Groups

pidgin

People

Description

Use a globally unique id when creating new Pidgin::DisplayItems as the doc demands and as discussed on discourse

Testing Done

Ran Pidgin and opened a conversation.

Commits

Summary	ID
use a globally unique id when creating new Pidgin::DisplayItem's	343139e5e7e2c6dc25124f39d3f887b7dba17c25

Issues

Description	From	Last Updated
This should really be using the conversation's id because names can and will change. If the protocol isn't setting an …	grim	Feb. 28, 2024, 6:10 a.m.
Similar to the above, this needs to use the account id instead of the account name. For example, on IRC …	grim	Feb. 28, 2024, 6:10 a.m.

pidgin/pidgindisplaywindow.c (Diff revision 1)

The issue has been resolved. Show all issues

This should really be using the conversation's id because names can and will change. If the protocol isn't setting an id for a conversation, the protocol needs to be fixed to do so.

pidgin/pidgindisplaywindow.c (Diff revision 1)

The issue has been resolved. Show all issues

Similar to the above, this needs to use the account id instead of the account name. For example, on IRC my nickname is normally grim, but I can change it to anything else while connected which would then break this.

Change Summary:

Use ids instead of names.

Commits:

	Summary	ID
	use a globally unique id when creating new Pidgin::DisplayItem's	2f6ffc7b01e11dab947ac3a97752ef52b5a47f72
	use a globally unique id when creating new Pidgin::DisplayItem's	343139e5e7e2c6dc25124f39d3f887b7dba17c25

Diff:

Revision 2 (+22 -4)

Show changes

pidgin/pidgindisplaywindow.c

Ship it!

```
Awesome work, thank you so much!!
```

Status:: Completed