Stop removing -Wall from CFLAGS

Review Request #2946 — Created Jan. 31, 2024 and submitted

Information

pidgin/pidgin
release-2.x.y

Reviewers

We really shouldn't override what the user has set externally. While it's true
that -Wall is set in DEBUG_CFLAGS later, dropping it from CFLAGS breaks
Perl detection somehow. Instead of going through the work to figure out how to
fix that, just stop modifying CFLAGS from the beginning.

Compiled on Rawhide with the attached patch.

Summary ID
Stop removing -Wall from CFLAGS
We really shouldn't override what the user has set externally. While it's true that `-Wall` is set for `DEBUG_CFLAGS` later, dropping it from `CFLAGS` breaks Perl detection somehow. Instead of going through the work to figure out how to fix that, just stop modifying `CFLAGS` from the beginning.
a158e45bd3c8f4bcf68730feb17d7e2dd9fb077d
grim
  1. Nice work, thanks!!

  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...