Create a test for verifying license headers and correct the ones that were wrong

Review Request #2940 — Created Jan. 26, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

We might want to move check_license_header.py script out to somewhere else,
but this is fine for now as we're just getting things going.

Compiled with the Turtles.

Summary ID
Create a test for verifying license headers and correct the ones that were wrong
We might want to move check_license_header.py script out to somewhere else, but this is fine for now as we're just getting things going.
d0ffd350fed82359b8bce4ca6d619e4bb634f39c
Description From Last Updated

It looks like a few files were missed: - glibcompat.h (a bit of a weird one) These the C files …

QuLogicQuLogic

This will only print usage if there's no args supplied to the script. Not sure if that's intentional.

ivanhoeivanhoe

Yea, this should probably be 4, not 2.

QuLogicQuLogic

These are tabs, not spaces.

QuLogicQuLogic

print, not printf.

QuLogicQuLogic

Extra ; and newline.

QuLogicQuLogic
ivanhoe
  1. 
      
  2. scripts/check_license_header.py (Diff revision 1)
     
     
    Show all issues

    This will only print usage if there's no args supplied to the script. Not sure if that's intentional.

  3. 
      
QuLogic
  1. 
      
  2. Show all issues

    It looks like a few files were missed:
    - glibcompat.h (a bit of a weird one)
    These the C files were changed, but not the headers:
    - *private.h
    - media/*.h
    - request/*.h

    Also missed, but fine if they're in a different review:
    - tests/*.[ch]
    - win32/*.[ch]

  3. scripts/check_license_header.py (Diff revision 1)
     
     
    Show all issues

    Yea, this should probably be 4, not 2.

  4. scripts/check_license_header.py (Diff revision 1)
     
     
     
    Show all issues

    These are tabs, not spaces.

  5. scripts/check_license_header.py (Diff revision 1)
     
     
    Show all issues

    print, not printf.

  6. scripts/check_license_header.py (Diff revision 1)
     
     
     
    Show all issues

    Extra ; and newline.

  7. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed