Summary

Create a test for verifying license headers and correct the ones that were wrong

Review Request #2940 — Created Jan. 26, 2024 and submitted Feb. 20, 2024, 7:25 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

We might want to move check_license_header.py script out to somewhere else,
but this is fine for now as we're just getting things going.

Testing Done

Compiled with the Turtles.

Commits

Summary	ID
Create a test for verifying license headers and correct the ones that were wrong We might want to move check_license_header.py script out to somewhere else, but this is fine for now as we're just getting things going.	d0ffd350fed82359b8bce4ca6d619e4bb634f39c

Issues

Description	From	Last Updated
It looks like a few files were missed: - glibcompat.h (a bit of a weird one) These the C files …	QuLogic	Feb. 20, 2024, 6:22 a.m.
This will only print usage if there's no args supplied to the script. Not sure if that's intentional.	ivanhoe	Feb. 19, 2024, 4:20 p.m.
Yea, this should probably be 4, not 2.	QuLogic	Feb. 20, 2024, 6:22 a.m.
These are tabs, not spaces.	QuLogic	Feb. 20, 2024, 6:22 a.m.
print, not printf.	QuLogic	Feb. 20, 2024, 6:22 a.m.
Extra ; and newline.	QuLogic	Feb. 20, 2024, 7:20 a.m.

scripts/check_license_header.py (Diff revision 1)

The issue has been resolved. Show all issues

This will only print usage if there's no args supplied to the script. Not sure if that's intentional.

The issue has been resolved. Show all issues

It looks like a few files were missed:
- glibcompat.h (a bit of a weird one)
These the C files were changed, but not the headers:
- *private.h
- media/*.h
- request/*.h

Also missed, but fine if they're in a different review:
- tests/*.[ch]
- win32/*.[ch]

scripts/check_license_header.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Yea, this should probably be 4, not 2.
```
scripts/check_license_header.py (Diff revision 1)
The issue has been resolved. Show all issues
```
These are tabs, not spaces.
```
scripts/check_license_header.py (Diff revision 1)
The issue has been resolved. Show all issues
```
print, not printf.
```
scripts/check_license_header.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra ; and newline.
```

Change Summary:

rebased, added missing files to the test, fixed the missing files, also added glibcompat.h to the libpurple target, and made the test verbose so we can save it's output and apply it to fix the license headers.

Commits:

	Summary	ID
	Create a test for verifying license headers and correct the ones that were wrong We might want to move check_license_header.py script out to somewhere else, but this is fine for now as we're just getting things going.	b1fc9270f996d43fee0075fa8b0e87a87a4ae7c9
	Create a test for verifying license headers and correct the ones that were wrong We might want to move check_license_header.py script out to somewhere else, but this is fine for now as we're just getting things going.	96bb239477a6b554193511561a7fb3a46863b6f3

Diff:

Revision 2 (+6908 -5928)

Show changes

	meson.build
	libpurple/accounts.h
	libpurple/accounts.c
	libpurple/action.h
	libpurple/action.c
	libpurple/blistnode.h
	libpurple/blistnode.c
	libpurple/buddy.h
	253 more

Change Summary:

Rebased and other clean ups

Commits:

	Summary	ID
	Create a test for verifying license headers and correct the ones that were wrong We might want to move check_license_header.py script out to somewhere else, but this is fine for now as we're just getting things going.	96bb239477a6b554193511561a7fb3a46863b6f3
	Create a test for verifying license headers and correct the ones that were wrong We might want to move check_license_header.py script out to somewhere else, but this is fine for now as we're just getting things going.	d0ffd350fed82359b8bce4ca6d619e4bb634f39c

Diff:

Revision 3 (+6904 -5928)

Show changes

	meson.build
	libpurple/accounts.h
	libpurple/accounts.c
	libpurple/action.h
	libpurple/action.c
	libpurple/blistnode.h
	libpurple/blistnode.c
	libpurple/buddy.h
	253 more

Ship it!

```
Ship It!
```

Status:: Completed