Add default saved presences for available and offline

Review Request #2907 — Created Jan. 2, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

These will be necessary in the near future so that the account manager has a
known presence to work with when starting up.

Ran the unit tests under valgrind.

Summary ID
Add default saved presences for available and offline
These will be necessary in the near future so that the account manager has a known presence to work with when starting up.
107fabe7d24d77b953c8c17a03167089b80622d0
Description From Last Updated

This is a little buggy; every time you remove index 0, g_list_model_get_n_items(model) reduces by 1, but you also increment i …

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/tests/test_presence_manager.c (Diff revision 1)
     
     
    Show all issues

    This is a little buggy; every time you remove index 0, g_list_model_get_n_items(model) reduces by 1, but you also increment i by one, so you'll only count half the number you need.

    Only one of these needs to change: either just check for n_items > 0 and drop i, or save n_items and increment i.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed