Summary

Add default saved presences for available and offline

Review Request #2907 — Created Jan. 2, 2024 and submitted Jan. 2, 2024, 6:54 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

These will be necessary in the near future so that the account manager has a
known presence to work with when starting up.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add default saved presences for available and offline These will be necessary in the near future so that the account manager has a known presence to work with when starting up.	107fabe7d24d77b953c8c17a03167089b80622d0

Issues

Description	From	Last Updated
This is a little buggy; every time you remove index 0, g_list_model_get_n_items(model) reduces by 1, but you also increment i …	QuLogic	Jan. 2, 2024, 6:47 a.m.

libpurple/tests/test_presence_manager.c (Diff revision 1)

The issue has been resolved. Show all issues

This is a little buggy; every time you remove index 0, g_list_model_get_n_items(model) reduces by 1, but you also increment i by one, so you'll only count half the number you need.

Only one of these needs to change: either just check for n_items > 0 and drop i, or save n_items and increment i.

Change Summary:

Make the removal loop less buggy.

Commits:

	Summary	ID
	Add default saved presences for available and offline These will be necessary in the near future so that the account manager has a known presence to work with when starting up.	e5643075bea3e1a4dbf0f0fd48060fbbd6d62964
	Add default saved presences for available and offline These will be necessary in the near future so that the account manager has a known presence to work with when starting up.	107fabe7d24d77b953c8c17a03167089b80622d0

Diff:

Revision 2 (+138 -2)

Show changes

	libpurple/purplepresencemanager.c
	libpurple/tests/test_presence_manager.c

Ship it!

```
Ship It!
```

Status:: Completed