Add BirbActionMenu

Review Request #2902 — Created Dec. 30, 2023 and submitted

Information

birb/birb
default

Reviewers

This class makes it easy to populate a menu via a signal emission.

Ran the unit tests under valgrind.

Summary ID
Add BirbActionMenu
This class makes it easy to populate a menu via a signal emission.
0585c9cd3136a2fa67888c5ccabffecded2c9c4d
Description From Last Updated

Hmm, GPL or LGPL? The repo doesn't have a license file right now, and I think I see both headers.

QuLogicQuLogic

s/does/did/

QuLogicQuLogic

Do we want to allow NULL for group to remove the prefix? (I vaguely remember some GTK API like that.)

QuLogicQuLogic
QuLogic
  1. 
      
  2. birb/birbactionmenu.h (Diff revision 1)
     
     

    Hmm, GPL or LGPL? The repo doesn't have a license file right now, and I think I see both headers.

    1. The license should match whatever libpurple is, which is weird if they're different...

    2. There's some inconsistencies with libpurple's licensing, but it's 202 GPL's to 28 LGPL's, so we should go with GPL.

  3. birb/birbactionmenu.h (Diff revision 1)
     
     

    s/does/did/

  4. birb/birbactionmenu.c (Diff revision 1)
     
     

    Do we want to allow NULL for group to remove the prefix? (I vaguely remember some GTK API like that.)

    1. If we're going to do this, lets do a separate function as g_hash_table_remove returns TRUE if it was found, but here we're returning TRUE if it didn't exist.

      At any rate, I don't think we need to worry about this yet, but maybe?

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...