Create a full widget for the new instant message window

Review Request #2896 — Created Dec. 28, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This now uses AdwMessageDialog and is self contained but PidginApplication
manages a singleton of it.

Previously this used the request api. I'm not sure why, as the request fields
were created by the ui itself.

Created an im with Echo on a demo account and was able to send and receive messages.

Summary ID
Create a full widget for the new instant message window
This now uses AdwMessageDialog and is self contained but PidginApplication manages a singleton of it. Previously this used the request api. I'm not sure why, as the request fields were created by the ui itself.
9b15dbc15c9fb93849482126f4ba15aa98baa497
Description From Last Updated

Should it be named IM window? We just got rid of separate conversation windows, but it seems like it might …

QuLogicQuLogic

No longer unused.

QuLogicQuLogic
QuLogic
  1. 
      
  2. Should it be named IM window? We just got rid of separate conversation windows, but it seems like it might be confusing. Also since it's a dialog, not a window.

    1. All true! I want to make some way more involed that determine if it's DM or Group DM and as the protocol plugin for lookups and stuff, but this was meant to be a stop gap to get rid of a bunch of deprecation warnings until all the building blocks are in the place for that.

    2. Ah, so will that be a '...Dialog' (or otherwise more correct name) so this one gets a "wrong" name to not clash?

    3. Well the new one will probably be something like PidginNewDirectMessageDialog and handle DMs and group DMs, where create channel would be something different.

      Honestly, I didn't put much thought into the name as my intention was to kill warnings :)

  3. pidgin/pidginapplication.c (Diff revision 1)
     
     

    No longer unused.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...