Summary

Create a full widget for the new instant message window

Review Request #2896 — Created Dec. 29, 2023 and submitted Jan. 2, 2024, 6:37 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This now uses AdwMessageDialog and is self contained but PidginApplication
manages a singleton of it.

Previously this used the request api. I'm not sure why, as the request fields
were created by the ui itself.

Testing Done

Created an im with Echo on a demo account and was able to send and receive messages.

Commits

Summary	ID
Create a full widget for the new instant message window This now uses AdwMessageDialog and is self contained but PidginApplication manages a singleton of it. Previously this used the request api. I'm not sure why, as the request fields were created by the ui itself.	9b15dbc15c9fb93849482126f4ba15aa98baa497

Issues

Description	From	Last Updated
Should it be named IM window? We just got rid of separate conversation windows, but it seems like it might …	QuLogic	Jan. 2, 2024, 6:23 a.m.
No longer unused.	QuLogic	Jan. 2, 2024, 6:15 a.m.

Show all issues

Should it be named IM window? We just got rid of separate conversation windows, but it seems like it might be confusing. Also since it's a dialog, not a window.

grim Jan. 2, 2024, 5:55 a.m.

All true! I want to make some way more involed that determine if it's DM or Group DM and as the protocol plugin for lookups and stuff, but this was meant to be a stop gap to get rid of a bunch of deprecation warnings until all the building blocks are in the place for that.

QuLogic Jan. 2, 2024, 6:16 a.m.

Ah, so will that be a '...Dialog' (or otherwise more correct name) so this one gets a "wrong" name to not clash?

grim Jan. 2, 2024, 6:21 a.m.

Well the new one will probably be something like PidginNewDirectMessageDialog and handle DMs and group DMs, where create channel would be something different.

Honestly, I didn't put much thought into the name as my intention was to kill warnings :)

pidgin/pidginapplication.c (Diff revision 1)
Show all issues
```
No longer unused.
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Create a full widget for the new instant message window This now uses AdwMessageDialog and is self contained but PidginApplication manages a singleton of it. Previously this used the request api. I'm not sure why, as the request fields were created by the ui itself.	d76125944b075a06619f08932561e43bf64b71ac
	Create a full widget for the new instant message window This now uses AdwMessageDialog and is self contained but PidginApplication manages a singleton of it. Previously this used the request api. I'm not sure why, as the request fields were created by the ui itself.	9b15dbc15c9fb93849482126f4ba15aa98baa497

Diff:

Revision 2 (+578 -160)

Show changes

	ChangeLog.API
	pidgin/gtkdialogs.h
	pidgin/gtkdialogs.c
	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/pidginimwindow.h
	pidgin/pidginimwindow.c
	pidgin/resources/imwindow.ui
	1 more

Ship it!

```
Ship It!
```

Review Board 6.0.2