Summary

Add XemeExtensionMap

Review Request #2887 — Created Dec. 17, 2023 and submitted Jan. 2, 2024, 6:44 a.m.

Information

Owner

grim

Repository

xeme/xeme

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This keeps track of a subset of XemeExtensions and makes it easier to parse
them.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	261a2359834595099de3b97e63f56b31f8fbd4d4

Issues

Description	From	Last Updated
The parse method is being rehashed at the moment as my initial idea sucked.	grim	Dec. 19, 2023, 6:31 a.m.
All the Since: 0.1.0 should be Since: 0.1 now, I think.	QuLogic	Jan. 2, 2024, 6:26 a.m.
Maybe also lookup existing one that should be there any more?	QuLogic	Jan. 2, 2024, 6:17 a.m.
char	QuLogic	Jan. 2, 2024, 6:18 a.m.
char	QuLogic	Jan. 2, 2024, 6:18 a.m.
an end_element	QuLogic	Jan. 2, 2024, 6:18 a.m.
Not really "whether", as it returns the extension, not TRUE/FALSE.	QuLogic	Jan. 2, 2024, 6:18 a.m.
an extension	QuLogic	Jan. 2, 2024, 6:18 a.m.
an end_element	QuLogic	Jan. 2, 2024, 6:19 a.m.
This should use g_slice_free, shouldn't it?	QuLogic	Jan. 2, 2024, 6:19 a.m.
Missing blank line.	QuLogic	Jan. 2, 2024, 6:19 a.m.
Not unused.	QuLogic	Jan. 2, 2024, 6:19 a.m.
char	QuLogic	Jan. 2, 2024, 6:19 a.m.
Not unused.	QuLogic	Jan. 2, 2024, 6:19 a.m.

Show all issues

The parse method is being rehashed at the moment as my initial idea sucked.

grim Dec. 19, 2023, 6:31 a.m.

This has been addressed in the most recent update.

Change Summary:

Clean up the parsing stuff but adding start and end functions as they are required to properly handle the subparsers in GMarkupParseContext

Commits:

	Summary	ID
	Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	5303c684fa095351f83584b950b398b0b80c0295
	Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	8c3839e1e66ad8e80f9ea00d77f83a776add8d66

Diff:

Revision 2 (+1414 -48)

Show changes

	xeme/meson.build
	xeme/xemeextension.h
	xeme/xemeextension.c
	xeme/xemeextensionmap.h
	xeme/xemeextensionmap.c
	xeme/xemeinputstream.c
	xeme/tests/meson.build
	xeme/tests/testextension.c
	1 more

xeme/tests/testextensionmap.c (Diff revision 2)

Show all issues

Maybe also lookup existing one that should be there any more?

xeme/tests/testextensionmap.c (Diff revision 2)
Show all issues
```
char
```
xeme/tests/testextensionmap.c (Diff revision 2)
Show all issues
```
char
```
xeme/xemeextension.h (Diff revision 2)
Show all issues
```
an end_element
```

xeme/xemeextensionmap.h (Diff revision 2)

Show all issues

Not really "whether", as it returns the extension, not TRUE/FALSE.

xeme/xemeextensionmap.h (Diff revision 2)
Show all issues
```
an extension
```
xeme/xemeextensionmap.h (Diff revision 2)
Show all issues
```
an end_element
```
xeme/xemeextensionmap.c (Diff revision 2)
Show all issues
```
This should use g_slice_free, shouldn't it?
```
xeme/xemeextensionmap.c (Diff revision 2)
Show all issues
```
Missing blank line.
```
xeme/xemeextensionmap.c (Diff revision 2)
Show all issues
```
Not unused.
```
xeme/xemeextensionmap.c (Diff revision 2)
Show all issues
```
char
```
xeme/xemeextensionmap.c (Diff revision 2)
Show all issues
```
Not unused.
```

Change Summary:

Addressed issues and plugged a memory leak we both missed.

Commits:

	Summary	ID
	Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	8c3839e1e66ad8e80f9ea00d77f83a776add8d66
	Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	d368790404d4ad68716dd64879823301a63b83c4

Diff:

Revision 3 (+1426 -48)

Show changes

	xeme/meson.build
	xeme/xemeextension.h
	xeme/xemeextension.c
	xeme/xemeextensionmap.h
	xeme/xemeextensionmap.c
	xeme/xemeinputstream.c
	xeme/tests/meson.build
	xeme/tests/testextension.c
	1 more

Show all issues

All the Since: 0.1.0 should be Since: 0.1 now, I think.

Change Summary:

Fix the since tags.

Commits:

	Summary	ID
	Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	d368790404d4ad68716dd64879823301a63b83c4
	Add XemeExtensionMap This keeps track of a subset of XemeExtensions and makes it easier to parse them.	261a2359834595099de3b97e63f56b31f8fbd4d4

Diff:

Revision 4 (+1426 -48)

Show changes

	xeme/meson.build
	xeme/xemeextension.h
	xeme/xemeextension.c
	xeme/xemeextensionmap.h
	xeme/xemeextensionmap.c
	xeme/xemeinputstream.c
	xeme/tests/meson.build
	xeme/tests/testextension.c
	1 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add XemeExtensionMap

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)