Summary

Add a dependency on birb and use its QueuedOutputStream

Review Request #2885 — Created Dec. 17, 2023 and submitted Dec. 17, 2023, 5:54 a.m.

Owner

grim

Repository

xeme/xeme

Branch

default

Bugs

Depends On

~~2884~~

Groups

People

Description

Wrap the output stream the user gives us in xeme_output_stream_start with
BirbQueuedOutputStream which handles pending writes so we don't have to.

Also cleaned up some memory leaks.

Testing Done

Ran the unit tests under valgrind with birb from /r/2884

Commits

Summary	ID
Add a dependency on birb and use its QueuedOutputStream Wrap the output stream the user gives us in xeme_output_stream_start with BirbQueuedOutputStream which handles pending writes so we don't have to.	ee786fe53b1ae279a7f97b579af11c8a31b9e6ef

Issues

Description	From	Last Updated
We need to update birb.wrap to whatever revision /r/2884 becomes.	grim	Dec. 17, 2023, 5:40 a.m.

The issue has been resolved. Show all issues

We need to update birb.wrap to whatever revision /r/2884 becomes.

Change Summary:

update to the correct birb version

Commits:

	Summary	ID
	Add a dependency on birb and use its QueuedOutputStream Wrap the output stream the user gives us in xeme_output_stream_start with BirbQueuedOutputStream which handles pending writes so we don't have to.	f3f373bc46162fa82baa5afaf193b756b81aa5e5
	Add a dependency on birb and use its QueuedOutputStream Wrap the output stream the user gives us in xeme_output_stream_start with BirbQueuedOutputStream which handles pending writes so we don't have to.	ee786fe53b1ae279a7f97b579af11c8a31b9e6ef

Diff:

	subprojects/birb.wrap
	xeme/xemeoutputstream.c
	xeme/xemestream.c
	xeme/tests/testoutputstream.c

Ship it!