-
-
-
libpurple/purplefiletransfermanager.c (Diff revision 1) This should be
g_ptr_array_new_with_free_func(g_object_unref)
, I think, as we add refs to all added transfers, and it's not unrefed when removed. -
libpurple/tests/test_file_transfer_manager.c (Diff revision 1) Contact manager has two separate counters for this, which might be safer?
Implement PurpleFileTransferManager
Review Request #2874 — Created Dec. 12, 2023 and submitted
This is a pretty simple manager as duplicates are allowed and PurpleFileTransfer all property driven which means we only need to propagate the notify signal. This doesn't persist across restarts as we have some other issues that are making that harder than it needs to be.
Ran the unit tests under valgrind.
Summary | ID |
---|---|
fef1bda8f72c5785264504145cbae1cc401a1956 |
Change Summary:
rebased and addressed issues.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1230 -2) |