Summary

Implement PurpleFileTransferManager

Review Request #2874 — Created Dec. 12, 2023 and submitted Jan. 1, 2024, 5:25 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17831

Depends On

Reviewers

Groups

pidgin

People

Description

This is a pretty simple manager as duplicates are allowed and
PurpleFileTransfer all property driven which means we only need to propagate
the notify signal.

This doesn't persist across restarts as we have some other issues that are
making that harder than it needs to be.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Implement PurpleFileTransferManager This is a pretty simple manager as duplicates are allowed and PurpleFileTransfer all property driven which means we only need to propagate the notify signal. This doesn't persist across restarts as we have some other issues that are making that harder than it needs to be.	fef1bda8f72c5785264504145cbae1cc401a1956

Issues

Description	From	Last Updated
its	QuLogic	Jan. 1, 2024, 5:18 a.m.
This should be g_ptr_array_new_with_free_func(g_object_unref), I think, as we add refs to all added transfers, and it's not unrefed when removed.	QuLogic	Jan. 1, 2024, 5:18 a.m.
Contact manager has two separate counters for this, which might be safer?	QuLogic	Jan. 1, 2024, 5:19 a.m.

libpurple/purplefiletransfermanager.h (Diff revision 1)
The issue has been resolved. Show all issues
```
its
```

libpurple/purplefiletransfermanager.c (Diff revision 1)

The issue has been resolved. Show all issues

This should be g_ptr_array_new_with_free_func(g_object_unref), I think, as we add refs to all added transfers, and it's not unrefed when removed.

libpurple/tests/test_file_transfer_manager.c (Diff revision 1)

The issue has been resolved. Show all issues

Contact manager has two separate counters for this, which might be safer?

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Implement PurpleFileTransferManager This is a pretty simple manager as duplicates are allowed and PurpleFileTransfer all property driven which means we only need to propagate the notify signal. This doesn't persist across restarts as we have some other issues that are making that harder than it needs to be.	59d9b3ab593c55ee37936c88ddd7baab2a18055e
	Implement PurpleFileTransferManager This is a pretty simple manager as duplicates are allowed and PurpleFileTransfer all property driven which means we only need to propagate the notify signal. This doesn't persist across restarts as we have some other issues that are making that harder than it needs to be.	fef1bda8f72c5785264504145cbae1cc401a1956

Diff:

Revision 2 (+1230 -2)

Show changes

	libpurple/meson.build
	libpurple/purplefiletransfer.h
	libpurple/purplefiletransfermanager.h
	libpurple/purplefiletransfermanager.c
	libpurple/purplefiletransfermanagerprivate.h
	libpurple/tests/meson.build
	libpurple/tests/test_file_transfer_manager.c

Ship it!

```
Ship It!
```

Status:: Completed