Remove some unused stuff from PurpleMessage

Review Request #2862 — Created Dec. 1, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Remove some unused stuff from PurpleMessage

Compiled and sent some messages to the echo bot and verified they were in the database.

Summary ID
Remove some unused stuff from PurpleMessage
64d446ded630e32e7d1d0ae6fc989ab700b976f9
Description From Last Updated

Should this get a db migration?

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/purplesqlitehistoryadapter.c (Diff revision 2)
     
     
     
     
     

    Should this get a db migration?

    1. We're just ignoring it right now, so it's probably fine to avoid? Like it doesn't break any existing queries or databases is what I mean.

    2. Ah, I figured that might be the case. Should we perhaps leave a note to clean it up (by just changing the schema directly) just before a release? (I guess I don't have a problem with breaking people using the pre-3.0.0 version for now.)

    3. Well we need to overhaul the schema in general. It worked to get something going, but we need to store account id's and something other stuff i think. I don't remember everything.

      Also iirc Eion did some testing and since it's not normalized it gets real big real quick.

    4. Also as we figure out the PurpleHistory GListModel impelementation it's very likely this structure is going to change even more.

  3. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...