- Bugs:
IRCv3: Update the signals so that handlers can inhibit the message from being displayed
Review Request #2858 — Created Dec. 1, 2023 and submitted
This was mainly added for DCC neogotiation, but could be useful in other ways.
Sent
CTCP VERSION
from irssi to a nick and a channel. Also sentCTCP VERSION
from pidgin 3 to a nick and channel.
Summary | ID |
---|---|
c8ea321a1671ff7a3b08cdd9a4456eb26f72df05 |
Description | From | Last Updated |
---|---|---|
Should you mention that message may be modified, as is done in the default handler? |
|
|
was handled |
|
|
an internationalized |
|
|
Ditto |
|
|
an internationalized |
|
|
This leaks. |
|
|
This leaks. |
|
|
Not checking conversation? |
|
|
Same here. |
|
|
Same here? |
|
|
I meant to ask earlier if this should also mention that message may be modified? |
|
|
Ditto. |
|
|
its |
|
- Change Summary:
-
Addressed issues
- Commits:
-
Summary ID 52314f6222b9f98c6c1747e89c5b5e1102fd915b a1298ab462024976f1d54bb47c9845b6054d476c
- Change Summary:
-
rebased and addressed issues.
- Commits:
-
Summary ID a1298ab462024976f1d54bb47c9845b6054d476c 67bd91ac4fab22eb86a2cab05119ffacd6ea336e
- Change Summary:
-
rebased and mention that message and conversation can be modified in the ctcp signal handlers.
- Commits:
-
Summary ID 67bd91ac4fab22eb86a2cab05119ffacd6ea336e fd6b7cd4b3fd06e81e01ddacb8a2823809d0e920