Summary

IRCv3: Update the signals so that handlers can inhibit the message from being displayed

Review Request #2858 — Created Dec. 1, 2023 and submitted Dec. 4, 2023, 8:20 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17721

Depends On

Blocks

2863

Reviewers

Groups

pidgin

People

Description

This was mainly added for DCC neogotiation, but could be useful in other ways.

Testing Done

Sent CTCP VERSION from irssi to a nick and a channel. Also sent CTCP VERSION from pidgin 3 to a nick and channel.

Commits

Summary	ID
IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	c8ea321a1671ff7a3b08cdd9a4456eb26f72df05

Issues

Description	From	Last Updated
Should you mention that message may be modified, as is done in the default handler?	QuLogic	Dec. 1, 2023, 7:04 a.m.
was handled	QuLogic	Dec. 1, 2023, 7:04 a.m.
an internationalized	QuLogic	Dec. 4, 2023, 7:19 a.m.
Ditto	QuLogic	Dec. 1, 2023, 7:04 a.m.
an internationalized	QuLogic	Dec. 4, 2023, 7:18 a.m.
This leaks.	QuLogic	Dec. 1, 2023, 7:04 a.m.
This leaks.	QuLogic	Dec. 1, 2023, 7:04 a.m.
Not checking conversation?	QuLogic	Dec. 1, 2023, 7:04 a.m.
Same here.	QuLogic	Dec. 1, 2023, 7:04 a.m.
Same here?	QuLogic	Dec. 1, 2023, 7:04 a.m.
I meant to ask earlier if this should also mention that message may be modified?	QuLogic	Dec. 4, 2023, 8:16 a.m.
Ditto.	QuLogic	Dec. 4, 2023, 8:14 a.m.
its	QuLogic	Dec. 4, 2023, 8:19 a.m.

Bugs:

+	PIDGIN-17721

Change Summary:

Fix typo.

Description:

~		This was mainly added for DCC neogotiation, but could be usefull in other ways.
	~	This was mainly added for DCC neogotiation, but could be useful in other ways.

libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)

Show all issues

Should you mention that message may be modified, as is done in the default handler?

libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)
Show all issues
```
was handled
```
libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)
Show all issues
```
Ditto
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
This leaks.
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
This leaks.
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
Not checking conversation?
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
Same here.
```
libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)
Show all issues
```
Same here?
```

Change Summary:

Addressed issues

Commits:

	Summary	ID
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	52314f6222b9f98c6c1747e89c5b5e1102fd915b
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	a1298ab462024976f1d54bb47c9845b6054d476c

Diff:

Revision 2 (+348 -182)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3ctcp.h
	libpurple/protocols/ircv3/purpleircv3ctcp.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

libpurple/protocols/ircv3/purpleircv3connection.h (Diff revisions 1 - 2)
Show all issues
```
an internationalized
```
libpurple/protocols/ircv3/purpleircv3connection.h (Diff revisions 1 - 2)
Show all issues
```
an internationalized
```

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 2)

Show all issues

I meant to ask earlier if this should also mention that message may be modified?

QuLogic Dec. 4, 2023, 7:59 a.m.

I see an update, but not sure this was put in?

grim Dec. 4, 2023, 8:01 a.m.

I only put it in the property documentation, but I can put it in the other places as well.

grim Dec. 4, 2023, 8:03 a.m.

sorry, all confused. I did put this in the method documentation, but not the signal documentation.

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 2)
Show all issues
```
Ditto.
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	a1298ab462024976f1d54bb47c9845b6054d476c
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	67bd91ac4fab22eb86a2cab05119ffacd6ea336e

Diff:

Revision 3 (+360 -182)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3ctcp.h
	libpurple/protocols/ircv3/purpleircv3ctcp.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

Change Summary:

rebased and mention that message and conversation can be modified in the ctcp signal handlers.

Commits:

	Summary	ID
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	67bd91ac4fab22eb86a2cab05119ffacd6ea336e
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	fd6b7cd4b3fd06e81e01ddacb8a2823809d0e920

Diff:

Revision 4 (+374 -182)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3ctcp.h
	libpurple/protocols/ircv3/purpleircv3ctcp.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revisions 3 - 4)
Show all issues
```
its
```

Ship it!

```
Ship It!
```

Change Summary:

rebased, fixed conflicts, and fixed typo

Commits:

	Summary	ID
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	fd6b7cd4b3fd06e81e01ddacb8a2823809d0e920
	IRCv3: Update the signals so that handlers can inhibit the message from being displayed This was mainly added for DCC neogotiation, but could be usefull in other ways.	c8ea321a1671ff7a3b08cdd9a4456eb26f72df05

Diff:

Revision 5 (+374 -182)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3ctcp.h
	libpurple/protocols/ircv3/purpleircv3ctcp.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

Review Board 6.0.2

IRCv3: Update the signals so that handlers can inhibit the message from being displayed

Information

Reviewers

Bugs:

Change Summary:

Description:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)