IRCv3: Update the signals so that handlers can inhibit the message from being displayed

Review Request #2858 — Created Dec. 1, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This was mainly added for DCC neogotiation, but could be useful in other ways.

Sent CTCP VERSION from irssi to a nick and a channel. Also sent CTCP VERSION from pidgin 3 to a nick and channel.

Summary ID
IRCv3: Update the signals so that handlers can inhibit the message from being displayed
This was mainly added for DCC neogotiation, but could be usefull in other ways.
c8ea321a1671ff7a3b08cdd9a4456eb26f72df05
Description From Last Updated

Should you mention that message may be modified, as is done in the default handler?

QuLogicQuLogic

was handled

QuLogicQuLogic

an internationalized

QuLogicQuLogic

Ditto

QuLogicQuLogic

an internationalized

QuLogicQuLogic

This leaks.

QuLogicQuLogic

This leaks.

QuLogicQuLogic

Not checking conversation?

QuLogicQuLogic

Same here.

QuLogicQuLogic

Same here?

QuLogicQuLogic

I meant to ask earlier if this should also mention that message may be modified?

QuLogicQuLogic

Ditto.

QuLogicQuLogic

its

QuLogicQuLogic
grim
QuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Should you mention that message may be modified, as is done in the default handler?

  3. Show all issues

    was handled

  4. Show all issues

    Ditto

  5. Show all issues

    This leaks.

  6. Show all issues

    This leaks.

  7. Show all issues

    Not checking conversation?

  8. Show all issues

    Same here.

  9. Show all issues

    Same here?

  10. 
      
grim
QuLogic
  1. 
      
  2. Show all issues

    an internationalized

  3. Show all issues

    an internationalized

  4. Show all issues

    I meant to ask earlier if this should also mention that message may be modified?

    1. I see an update, but not sure this was put in?

    2. I only put it in the property documentation, but I can put it in the other places as well.

    3. sorry, all confused. I did put this in the method documentation, but not the signal documentation.

  5. Show all issues

    Ditto.

  6. 
      
grim
grim
QuLogic
  1. 
      
  2. Show all issues

    its

  3. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
grim
Review request changed
Status:
Completed