IRCv3: Implement basic CTCP support

Review Request #2854 — Created Nov. 30, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This is just the scaffolding for it and doesn't implement any actual commands.

Sent some CTCP VERSION's to an IRCv3 account. Also manually sent CTCP VERSION's to users and channel via temporary code in when the connection was fully established.

Summary ID
IRCv3: Implement basic CTCP support
This is just the scaffolding for it and doesn't implement any actual commands.
5f144dada08d50549a827cdeec4cf39b5817d2ec
Description From Last Updated

Are these (nullable)? There's no check in the helper functions, so I would assume so.

QuLogicQuLogic

Ditto

QuLogicQuLogic

Misaligned.

QuLogicQuLogic

Missing space around -.

QuLogicQuLogic

How come this side can assume params != NULL?

QuLogicQuLogic

I think translations don't usually like string generation part-by-part like this; better to be two strings with/without params (and then …

QuLogicQuLogic

Should this return TRUE/FALSE?

QuLogicQuLogic
QuLogic
  1. 
      
  2. Show all issues

    Are these (nullable)? There's no check in the helper functions, so I would assume so.

  3. Show all issues

    Ditto

  4. Show all issues

    Misaligned.

  5. libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)
     
     
     
    Show all issues

    Missing space around -.

  6. libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)
     
     
     
    Show all issues

    How come this side can assume params != NULL?

  7. libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)
     
     
     
     
     
    Show all issues

    I think translations don't usually like string generation part-by-part like this; better to be two strings with/without params (and then no need for GString).

  8. Show all issues

    Should this return TRUE/FALSE?

    1. I wanted to get there in this rr, but I figured it was going to exploded it out a bit as we'd need to add in the signal accumulator stuff and a default implementation and stuff.

  9. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed