-
-
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1) Are these
(nullable)? There's no check in the helper functions, so I would assume so. -
-
-
-
libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1) How come this side can assume
params != NULL? -
libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1) I think translations don't usually like string generation part-by-part like this; better to be two strings with/without
params(and then no need forGString). -
libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1) Should this return
TRUE/FALSE?
IRCv3: Implement basic CTCP support
Review Request #2854 — Created Nov. 30, 2023 and submitted
This is just the scaffolding for it and doesn't implement any actual commands.
Sent some
CTCP VERSION's to an IRCv3 account. Also manually sentCTCP VERSION's to users and channel via temporary code in when the connection was fully established.
| Summary | ID |
|---|---|
| 5f144dada08d50549a827cdeec4cf39b5817d2ec |
| Description | From | Last Updated |
|---|---|---|
|
Are these (nullable)? There's no check in the helper functions, so I would assume so. |
 QuLogic
|
|
|
Ditto |
QuLogic
|
|
|
Misaligned. |
QuLogic
|
|
|
Missing space around -. |
QuLogic
|
|
|
How come this side can assume params != NULL? |
QuLogic
|
|
|
I think translations don't usually like string generation part-by-part like this; better to be two strings with/without params (and then … |
QuLogic
|
|
|
Should this return TRUE/FALSE? |
QuLogic
|
Change Summary:
rebased and addressed issues
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+530) |