Summary

IRCv3: Implement basic CTCP support

Review Request #2854 — Created Nov. 30, 2023 and submitted Dec. 1, 2023, 4:39 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is just the scaffolding for it and doesn't implement any actual commands.

Testing Done

Sent some CTCP VERSION's to an IRCv3 account. Also manually sent CTCP VERSION's to users and channel via temporary code in when the connection was fully established.

Commits

Summary	ID
IRCv3: Implement basic CTCP support This is just the scaffolding for it and doesn't implement any actual commands.	5f144dada08d50549a827cdeec4cf39b5817d2ec

Issues

Description	From	Last Updated
Are these (nullable)? There's no check in the helper functions, so I would assume so.	QuLogic	Dec. 1, 2023, 4:35 a.m.
Ditto	QuLogic	Dec. 1, 2023, 4:35 a.m.
Misaligned.	QuLogic	Dec. 1, 2023, 4:35 a.m.
Missing space around -.	QuLogic	Dec. 1, 2023, 4:35 a.m.
How come this side can assume params != NULL?	QuLogic	Dec. 1, 2023, 4:36 a.m.
I think translations don't usually like string generation part-by-part like this; better to be two strings with/without params (and then …	QuLogic	Dec. 1, 2023, 4:36 a.m.
Should this return TRUE/FALSE?	QuLogic	Dec. 1, 2023, 4:36 a.m.

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Are these (nullable)? There's no check in the helper functions, so I would assume so.
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Misaligned.
```
libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing space around -.
```
libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)
The issue has been resolved. Show all issues
```
How come this side can assume params != NULL?
```

libpurple/protocols/ircv3/purpleircv3ctcp.c (Diff revision 1)

The issue has been resolved. Show all issues

I think translations don't usually like string generation part-by-part like this; better to be two strings with/without params (and then no need for GString).

libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)

The issue has been dropped. Show all issues

Should this return TRUE/FALSE?

grim Dec. 1, 2023, 4:32 a.m.

I wanted to get there in this rr, but I figured it was going to exploded it out a bit as we'd need to add in the signal accumulator stuff and a default implementation and stuff.

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	IRCv3: Implement basic CTCP support This is just the scaffolding for it and doesn't implement any actual commands.	56225e67c543e764ad4847836e2573ef09e9fbe1
	IRCv3: Implement basic CTCP support This is just the scaffolding for it and doesn't implement any actual commands.	5f144dada08d50549a827cdeec4cf39b5817d2ec

Diff:

Revision 2 (+530)

Show changes

	libpurple/protocols/ircv3/meson.build
	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3constants.h
	libpurple/protocols/ircv3/purpleircv3ctcp.h
	libpurple/protocols/ircv3/purpleircv3ctcp.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

Ship it!

```
Ship It!
```

Status:: Completed