Updated purple_conversation_remove_member to take a PurpleContactInfo

Review Request #2844 — Created Nov. 22, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

All of the purple_conversation_*_member methods took a PurpleContactInfo except
for remove which this addresses. This makes the API more consistent and easier
to use as the protocols will generally have a PurpleContactInfo but not a
PurpleConversationMember when doing member management. That additional lookup
caused us to have to iterate the list twice where now it's only one.

Ran the unit tests

Summary ID
Updated purple_conversation_remove_member to take a PurpleContactInfo
All of the purple_conversation_*_member methods took a PurpleContactInfo except for remove which this addresses. This makes the API more consistent and easier to use as the protocols will generally have a PurpleContactInfo but not a PurpleConversationMember when doing member management. That additional lookup caused us to have to iterate the list twice where now it's only one.
bdb27fc1b1704515917f4ac2da8f4958fd97295e
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...