Summary

Updated purple_conversation_remove_member to take a PurpleContactInfo

Review Request #2844 — Created Nov. 22, 2023 and submitted Dec. 4, 2023, 1:25 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

All of the purple_conversation_*_member methods took a PurpleContactInfo except
for remove which this addresses. This makes the API more consistent and easier
to use as the protocols will generally have a PurpleContactInfo but not a
PurpleConversationMember when doing member management. That additional lookup
caused us to have to iterate the list twice where now it's only one.

Testing Done

Ran the unit tests

Commits

Summary	ID
Updated purple_conversation_remove_member to take a PurpleContactInfo All of the purple_conversation_*_member methods took a PurpleContactInfo except for remove which this addresses. This makes the API more consistent and easier to use as the protocols will generally have a PurpleContactInfo but not a PurpleConversationMember when doing member management. That additional lookup caused us to have to iterate the list twice where now it's only one.	bdb27fc1b1704515917f4ac2da8f4958fd97295e

Summary

Updated purple_conversation_remove_member to take a PurpleContactInfo

All of the purple_conversation_*_member methods took a PurpleContactInfo except for remove which this addresses. This makes the API more consistent and easier to use as the protocols will generally have a PurpleContactInfo but not a PurpleConversationMember when doing member management. That additional lookup caused us to have to iterate the list twice where now it's only one.

bdb27fc1b1704515917f4ac2da8f4958fd97295e

Ship it!

```
Ship It!
```

Status:: Completed