Summary

Add a propagation signal for populate-menu to PurpleContactManager

Review Request #2838 — Created Nov. 19, 2023 and submitted Jan. 23, 2024, 7:39 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2837~~, ~~2902~~

Reviewers

Groups

pidgin

People

Description

Add a propagation signal for populate-menu to PurpleContactManager

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add a propagation signal for populate-menu to PurpleContactManager	6f1c490e53697488d190cfb129ad2061b37b0ec3

Issues

Description	From	Last Updated
Will this need a propagation signal for populate-actions as well?	QuLogic	Jan. 23, 2024, 7:24 a.m.
3.0 (actually I missed the same on /r/2837)	QuLogic	Jan. 23, 2024, 7:38 a.m.

The issue has been resolved. Show all issues

Will this need a propagation signal for populate-actions as well?

grim Nov. 19, 2023, 6:07 a.m.

yes, I was trying to imply that with the comment, but I should have been explicit.

Depends On:: ~~2902 - Add BirbActionMenu~~

Change Summary:

Rebased on top of 2837 and updated to use birb.

Commits:

	Summary	ID
	Add a propagation signal for populate-menu to PurpleContactManager	15feebeaff79be1bd0f3775563c3eefe24d67c26
	Add a propagation signal for populate-menu to PurpleContactManager	9a742586f68ff4e01a5195302208bb08111c5c01

Diff:

Revision 2 (+216 -10)

Show changes

	libpurple/purplecontactmanager.c
	libpurple/tests/test_contact_manager.c

Change Summary:

rebased

Commits:

	Summary	ID
	Add a propagation signal for populate-menu to PurpleContactManager	9a742586f68ff4e01a5195302208bb08111c5c01
	Add a propagation signal for populate-menu to PurpleContactManager	74d307ce7c7e3909531daef5fff01d8d08749b89

Diff:

Revision 3 (+216 -10)

Show changes

	libpurple/purplecontactmanager.c
	libpurple/tests/test_contact_manager.c

libpurple/purplecontactmanager.c (Diff revision 3)
The issue has been resolved. Show all issues
```
3.0 (actually I missed the same on /r/2837)
```

Change Summary:

fix since tags.

Commits:

	Summary	ID
	Add a propagation signal for populate-menu to PurpleContactManager	74d307ce7c7e3909531daef5fff01d8d08749b89
	Add a propagation signal for populate-menu to PurpleContactManager	6f1c490e53697488d190cfb129ad2061b37b0ec3

Diff:

Revision 4 (+354 -148)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/purplecontactmanager.h
	libpurple/purplecontactmanager.c
	libpurple/tests/test_contact_manager.c

Ship it!

```
Ship It!
```

Status:: Completed