Change Summary:
Fix typos
Summary: |
|
||||||
|---|---|---|---|---|---|---|---|
Description: |
|
Move the contact list item to its own ui file
Review Request #2836 — Created Nov. 19, 2023 and submitted
This makes it easier to read instead of having an embedded ui file.
Connected the demo account and verified the contacts were still displayed.
| Summary | ID |
|---|---|
| 6f90610c8dae70cdd5f1a8786fdde992fc1ec8c5 |
| Description | From | Last Updated |
|---|---|---|
|
I wonder if the swapped and object can be dropped now that the file is separate? |
 QuLogic
|
|
|
Extra blank line |
QuLogic
|
|
|
I just noticed, it looks like we keep subdirectories first, so contactlistitem.ui should move down about 3 lines. |
QuLogic
|
|
|
Ditto here (though we seem to be missing some of the other top-level .ui here. |
QuLogic
|
-
-
pidgin/resources/contactlistitem.ui (Diff revision 1) I wonder if the
swappedandobjectcan be dropped now that the file is separate? -
Change Summary:
Rebase and address issues
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+228 -202) |
Change Summary:
add the ui file to POTFILES.in
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+230 -202) |
-
-
pidgin/resources/pidgin.gresource.xml (Diff revision 3) I just noticed, it looks like we keep subdirectories first, so
contactlistitem.uishould move down about 3 lines. -
po/POTFILES.in (Diff revision 3) Ditto here (though we seem to be missing some of the other top-level
.uihere.
Change Summary:
rebased and address issues.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+230 -202) |