Move the contact list item to its own ui file

Review Request #2836 — Created Nov. 19, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This makes it easier to read instead of having an embedded ui file.

Connected the demo account and verified the contacts were still displayed.

Summary ID
Move the contact list item to it's own ui file
This makes it easier to read instead of having and embeded ui file.
6f90610c8dae70cdd5f1a8786fdde992fc1ec8c5
Description From Last Updated

I wonder if the swapped and object can be dropped now that the file is separate?

QuLogicQuLogic

Extra blank line

QuLogicQuLogic

I just noticed, it looks like we keep subdirectories first, so contactlistitem.ui should move down about 3 lines.

QuLogicQuLogic

Ditto here (though we seem to be missing some of the other top-level .ui here.

QuLogicQuLogic
QuLogic
QuLogic
  1. 
      
  2. pidgin/resources/contactlistitem.ui (Diff revision 1)
     
     
     
    Show all issues

    I wonder if the swapped and object can be dropped now that the file is separate?

  3. pidgin/resources/contactlistitem.ui (Diff revision 1)
     
     
     
     
    Show all issues

    Extra blank line

  4. 
      
grim
grim
QuLogic
  1. 
      
  2. pidgin/resources/pidgin.gresource.xml (Diff revision 3)
     
     
     
     
     
    Show all issues

    I just noticed, it looks like we keep subdirectories first, so contactlistitem.ui should move down about 3 lines.

  3. po/POTFILES.in (Diff revision 3)
     
     
     
     
    Show all issues

    Ditto here (though we seem to be missing some of the other top-level .ui here.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed