Summary

IRCv3: rejoin channels after reconnect

Review Request #2829 — Created Nov. 17, 2023 and submitted Nov. 19, 2023, 6:37 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

We rejoin after registration to make sure that the user is identified and has
all their user modes set and whatever. We don't actually have a way to do this
right now, but plugins can tie into the signal for that.

Testing Done

Joined some channels on my local ergo, disconnected the account in the account manager, re-enabled it, and verified via another client that I rejoined those channels.

Commits

Summary	ID
IRCv3: rejoin channels after reconnect We rejoin after registration to make sure that the user is identified and has all their user modes set and whatever. We don't actually have a way to do this right now, but plugins can tie into the signal for that.	a9887df166bbc8aa14ff913f8c7814054ed1fc46

Issues

Description	From	Last Updated
Should this command get a macro?	QuLogic	Nov. 19, 2023, 6:26 a.m.
Might as well be NULL for an empty string, though I suppose you could pass the macro instead.	QuLogic	Nov. 19, 2023, 6:36 a.m.

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
Show all issues
```
Should this command get a macro?
```

Change Summary:

rebase, add macro, use macro everywhere, and some drive byes.

Commits:

	Summary	ID
	IRCv3: rejoin channels after reconnect We rejoin after registration to make sure that the user is identified and has all their user modes set and whatever. We don't actually have a way to do this right now, but plugins can tie into the signal for that.	cb02b33a50acfc939ceba35fad6331e397e6e9d7
	IRCv3: rejoin channels after reconnect We rejoin after registration to make sure that the user is identified and has all their user modes set and whatever. We don't actually have a way to do this right now, but plugins can tie into the signal for that.	1e716c21e8ca9c9559cd498a165378b6bdbe0915

Diff:

Revision 2 (+96 -12)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3constants.h
	libpurple/protocols/ircv3/purpleircv3protocolconversation.c
	libpurple/protocols/ircv3/tests/test_ircv3_parser.c

Ship it!

```
Ship It!
```

libpurple/protocols/ircv3/purpleircv3protocolconversation.c (Diff revision 2)

Show all issues

Might as well be NULL for an empty string, though I suppose you could pass the macro instead.

grim Nov. 19, 2023, 6:32 a.m.

If we did the macro, then we'd need a leading space when we add the channel name which can easily be overlooked, which I why I opted to do it all in the printf.

Change Summary:

pass NULL to g_string_new instead of an empty string.

Commits:

	Summary	ID
	IRCv3: rejoin channels after reconnect We rejoin after registration to make sure that the user is identified and has all their user modes set and whatever. We don't actually have a way to do this right now, but plugins can tie into the signal for that.	1e716c21e8ca9c9559cd498a165378b6bdbe0915
	IRCv3: rejoin channels after reconnect We rejoin after registration to make sure that the user is identified and has all their user modes set and whatever. We don't actually have a way to do this right now, but plugins can tie into the signal for that.	a9887df166bbc8aa14ff913f8c7814054ed1fc46

Diff:

Revision 3 (+96 -12)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3constants.h
	libpurple/protocols/ircv3/purpleircv3protocolconversation.c
	libpurple/protocols/ircv3/tests/test_ircv3_parser.c

Review Board 6.0.2

IRCv3: rejoin channels after reconnect

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)