Summary

Port PidginAwayPrefs to PurpleSavedPresence and GSettings

Review Request #2813 — Created Nov. 14, 2023 and submitted Nov. 17, 2023, 7 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

I didn't port the stuff that uses these settings because that stuff is still incomplete.

Testing Done

Set all of the settings in the dialog as well as from pidgin3.ini and verified everything updated properly.

Commits

Summary	ID
Port PidginAwayPrefs to PurpleSavedPresence and GSettings	dffea3eb379fad82767d1ddfbb036d983a25016d

Issues

Description	From	Last Updated
Theoretically, you could return FALSE in an else, I guess? But maybe not necessary if that'll never happen.	QuLogic	Nov. 17, 2023, 6:59 a.m.
This leaks.	QuLogic	Nov. 17, 2023, 6:59 a.m.
Weird indent.	QuLogic	Nov. 17, 2023, 6:59 a.m.
s/settings/setting/	QuLogic	Nov. 17, 2023, 6:59 a.m.

pidgin/prefs/pidginawayprefs.c (Diff revision 1)

Show all issues

Theoretically, you could return FALSE in an else, I guess? But maybe not necessary if that'll never happen.

pidgin/prefs/pidginawayprefs.c (Diff revision 1)
Show all issues
```
This leaks.
```
pidgin/prefs/pidginawayprefs.c (Diff revision 1)
Show all issues
```
Weird indent.
```
pidgin/prefs/pidginawayprefs.c (Diff revision 1)
Show all issues
```
s/settings/setting/
```

Rebased and addressed issues.

	Summary	ID
	Port PidginAwayPrefs to PurpleSavedPresence and GSettings	a85218410c91e5e3f070e9d3e75d75819b9fe93f
	Port PidginAwayPrefs to PurpleSavedPresence and GSettings	dffea3eb379fad82767d1ddfbb036d983a25016d

Revision 2 (+492 -816)

	ChangeLog.API
	libpurple/data/im.pidgin.Purple.gschema.xml
	pidgin/gtksavedstatuses.h
	pidgin/gtksavedstatuses.c
	pidgin/meson.build
	pidgin/pidginapplication.c
	pidgin/prefs/pidginawayprefs.c
	pidgin/resources/Prefs/away.ui
	1 more

Ship it!

Review Board 6.0.2