Port PidginAwayPrefs to PurpleSavedPresence and GSettings

Review Request #2813 — Created Nov. 14, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

I didn't port the stuff that uses these settings because that stuff is still incomplete.

Set all of the settings in the dialog as well as from pidgin3.ini and verified everything updated properly.

Summary ID
Port PidginAwayPrefs to PurpleSavedPresence and GSettings
dffea3eb379fad82767d1ddfbb036d983a25016d
Description From Last Updated

Theoretically, you could return FALSE in an else, I guess? But maybe not necessary if that'll never happen.

QuLogicQuLogic

This leaks.

QuLogicQuLogic

Weird indent.

QuLogicQuLogic

s/settings/setting/

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/prefs/pidginawayprefs.c (Diff revision 1)
     
     
    Show all issues

    Theoretically, you could return FALSE in an else, I guess? But maybe not necessary if that'll never happen.

  3. pidgin/prefs/pidginawayprefs.c (Diff revision 1)
     
     
    Show all issues

    This leaks.

  4. pidgin/prefs/pidginawayprefs.c (Diff revision 1)
     
     
     
    Show all issues

    Weird indent.

  5. pidgin/prefs/pidginawayprefs.c (Diff revision 1)
     
     
    Show all issues

    s/settings/setting/

  6. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed