Summary

Replace the old appdata file with an appstream metainfo file

Review Request #2800 — Created Nov. 13, 2023 and submitted Nov. 14, 2023, 2:43 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Also moved the stuff in pidgin/meson.build that was touching files pidgin/data
to pidgin/data/meson.build since that already existed.

Testing Done

Ran the unit tests a lot.

Commits

Summary	ID
Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	da6b7eec93f3f2fc2b19c60ab6c1841958174f34

Issues

Description	From	Last Updated
Pidgin3?	QuLogic	Nov. 14, 2023, 1:50 a.m.
The .desktop file uses the full reverse DNS name, like the metainfo, doesn't it? Do we need the provides since …	QuLogic	Nov. 14, 2023, 2:10 a.m.
Pidgin3 for the last component	QuLogic	Nov. 14, 2023, 2:42 a.m.
Not sure about these two, as the application doesn't have any of those, but I'm not sure if there's any …	QuLogic	Nov. 14, 2023, 2:42 a.m.

pidgin/data/im.pidgin.Pidgin3.metainfo.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
Pidgin3?
```

pidgin/data/im.pidgin.Pidgin3.metainfo.xml (Diff revision 1)

The issue has been resolved. Show all issues

The .desktop file uses the full reverse DNS name, like the metainfo, doesn't it? Do we need the provides since nothing ever provided pidgin3.desktop?

QuLogic Nov. 14, 2023, 1:50 a.m.

Note that the binary part might still be okay?

Change Summary:

rebased, addressed issues, and added validation for the desktop file.

Commits:

	Summary	ID
	Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	62eee1ff70801a62d9f03abb215772eaecb5ff1e
	Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	9350c09b90de16a9b339c3a8cb8e9317a2449551

Diff:

Revision 2 (+940 -140)

Show changes

	pidgin/meson.build
	pidgin/data/im.pidgin.Pidgin3.appdata.xml.in
	pidgin/data/im.pidgin.Pidgin3.metainfo.xml
	pidgin/data/meson.build
	po/POTFILES.in

Change Summary:

put the provides back with the binary.

Commits:

	Summary	ID
	Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	9350c09b90de16a9b339c3a8cb8e9317a2449551
	Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	aeed6e4f1075b09411dbec6e40876c9e5fde5085

Diff:

Revision 3 (+948 -140)

Show changes

	pidgin/meson.build
	pidgin/data/im.pidgin.Pidgin3.appdata.xml.in
	pidgin/data/im.pidgin.Pidgin3.metainfo.xml
	pidgin/data/meson.build
	po/POTFILES.in

Ship it!

```
Ship It!
```
pidgin/data/im.pidgin.Pidgin3.metainfo.xml (Diff revision 3)
The issue has been resolved. Show all issues
```
Pidgin3 for the last component
```

pidgin/data/im.pidgin.Pidgin3.metainfo.xml (Diff revision 3)

The issue has been resolved. Show all issues

Not sure about these two, as the application doesn't have any of those, but I'm not sure if there's any real delineation for user-provided content.

grim Nov. 14, 2023, 2:41 a.m.

Yeah I'm not sure either.. we can drop 'em for now as pidgin2 didn't have 'em so eyah..

Change Summary:

address issues

Commits:

	Summary	ID
	Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	aeed6e4f1075b09411dbec6e40876c9e5fde5085
	Replace the old appdata file with an appstream metainfo file Also moved the stuff in pidgin/meson.build that was touching files pidgin/data to pidgin/data/meson.build since that already existed.	da6b7eec93f3f2fc2b19c60ab6c1841958174f34

Diff:

Revision 4 (+944 -140)

Show changes

	pidgin/meson.build
	pidgin/data/im.pidgin.Pidgin3.appdata.xml.in
	pidgin/data/im.pidgin.Pidgin3.metainfo.xml
	pidgin/data/meson.build
	po/POTFILES.in

Status:: Completed