IRCv3: create some helper functions for finding/creating conversations

 






 

 


  Review Request #2799
  —
  Created Nov. 13, 2023 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This is necessary so we can start properly handling other channel messages as
we could miss a join message from a bouncer but then get join, part, etc.

 








  


 
 

  
Received a dm and verified the conversation was created properly.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      IRCv3: create some helper functions for finding/creating conversations
      
This is necessary so we can start properly handling other channel messages as
we could miss a join message from a bouncer but then get join, part, etc.

     


    		
    b01d8cd1afaaa0a2d1907af4088c5ce9029cff77

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
s/instance conversation/conversation instance/ ? Additionally, should this maybe mention that the conversation manager takes ownership of the newly created conversation?

      		
      
       ivanhoeivanhoe
      
      
       
      
     




     

      
       
       
Should also add (nullable) I think.

      		
      
       ivanhoeivanhoe
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    s/instance conversation/conversation instance/ ?
    

    Additionally, should this maybe mention that the conversation manager takes ownership of the newly created conversation?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Well that's implied in the transfer none but I could make it explicit.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should also add (nullable) I think.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      It should never be null. It either gives you an existings or creates a new one.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      You're right, the g_return_val_if_fail's can cause it to be NULL
      
 
      

      3. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




ivanhoe




   

   







  

 



 

  


   

   

    
 
ivanhoe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...