Summary

IRCv3: create some helper functions for finding/creating conversations

Review Request #2799 — Created Nov. 12, 2023 and submitted Nov. 14, 2023, 12:27 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is necessary so we can start properly handling other channel messages as
we could miss a join message from a bouncer but then get join, part, etc.

Testing Done

Received a dm and verified the conversation was created properly.

Commits

Summary	ID
IRCv3: create some helper functions for finding/creating conversations This is necessary so we can start properly handling other channel messages as we could miss a join message from a bouncer but then get join, part, etc.	b01d8cd1afaaa0a2d1907af4088c5ce9029cff77

Issues

Description	From	Last Updated
s/instance conversation/conversation instance/ ? Additionally, should this maybe mention that the conversation manager takes ownership of the newly created conversation?	ivanhoe	Nov. 14, 2023, 12:24 a.m.
Should also add (nullable) I think.	ivanhoe	Nov. 14, 2023, 12:24 a.m.

libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)

The issue has been resolved. Show all issues

s/instance conversation/conversation instance/ ?

Additionally, should this maybe mention that the conversation manager takes ownership of the newly created conversation?

grim Nov. 13, 2023, 7:02 p.m.

Well that's implied in the transfer none but I could make it explicit.

libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)

The issue has been resolved. Show all issues

Should also add (nullable) I think.

grim Nov. 13, 2023, 7:02 p.m.

It should never be null. It either gives you an existings or creates a new one.

grim Nov. 13, 2023, 8:54 p.m.

You're right, the g_return_val_if_fail's can cause it to be NULL

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	IRCv3: create some helper functions for finding/creating conversations This is necessary so we can start properly handling other channel messages as we could miss a join message from a bouncer but then get join, part, etc.	3128e40269a03b6b7ede8d1821dfbd1d6184b2e2
	IRCv3: create some helper functions for finding/creating conversations This is necessary so we can start properly handling other channel messages as we could miss a join message from a bouncer but then get join, part, etc.	b01d8cd1afaaa0a2d1907af4088c5ce9029cff77

Diff:

Revision 2 (+186 -74)

Show changes

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

Ship it!

```
Ship It!
```

Status:: Completed