Make broadwayd optional for unit testing

Review Request #2779 — Created Nov. 5, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

gtk4-broadwayd isn't packaged for at least homebrew on macOS and maybe others,
so this only runs the broadway tests if broadway is found.

Ran turtles normally and with the executable name tweaked so it couldn't be found.

Summary ID
Make broadwayd optional for unit testing
gtk4-broadwayd isn't packaged for at least homebrew on macOS and maybe others, so this only runs the broadway tests if broadway is found.
cba7e7756a151769044be1f4d79d223a392bdf20
Description From Last Updated

It's not available on Windows either, so good to skip there as well.

QuLogicQuLogic

Did you mean 4-space indent here? (We usually do tab, though Meson upstream is 2-space.)

QuLogicQuLogic

'usage: ' should go before the program name? Also, 'tests' is a bit misleading as it seems like multiple tests …

QuLogicQuLogic
QuLogic
  1. 
      
  2. Show all issues

    It's not available on Windows either, so good to skip there as well.

    1. wouldn't that just work because the executable won't be found?

    2. I meant this change is good for that; didn't mean to open it as an issue.

  3. pidgin/tests/meson.build (Diff revision 1)
     
     
    Show all issues

    Did you mean 4-space indent here? (We usually do tab, though Meson upstream is 2-space.)

  4. pidgin/tests/test-wrapper.py (Diff revision 1)
     
     
    Show all issues

    'usage: ' should go before the program name?

    Also, 'tests' is a bit misleading as it seems like multiple tests are allowed, but really all arguments are run together (i.e., it's [test] [test arguments] or similar.)

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed