Summary

Make broadwayd optional for unit testing

Review Request #2779 — Created Nov. 5, 2023 and submitted Nov. 7, 2023, 1:05 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

gtk4-broadwayd isn't packaged for at least homebrew on macOS and maybe others,
so this only runs the broadway tests if broadway is found.

Testing Done

Ran turtles normally and with the executable name tweaked so it couldn't be found.

Commits

Summary	ID
Make broadwayd optional for unit testing gtk4-broadwayd isn't packaged for at least homebrew on macOS and maybe others, so this only runs the broadway tests if broadway is found.	cba7e7756a151769044be1f4d79d223a392bdf20

Issues

Description	From	Last Updated
It's not available on Windows either, so good to skip there as well.	QuLogic	Nov. 6, 2023, 1:13 a.m.
Did you mean 4-space indent here? (We usually do tab, though Meson upstream is 2-space.)	QuLogic	Nov. 6, 2023, 1:13 a.m.
'usage: ' should go before the program name? Also, 'tests' is a bit misleading as it seems like multiple tests …	QuLogic	Nov. 7, 2023, 12:48 a.m.

The issue has been dropped. Show all issues

It's not available on Windows either, so good to skip there as well.

grim Nov. 6, 2023, 1:04 a.m.

wouldn't that just work because the executable won't be found?

QuLogic Nov. 6, 2023, 1:13 a.m.

I meant this change is good for that; didn't mean to open it as an issue.

pidgin/tests/meson.build (Diff revision 1)

The issue has been resolved. Show all issues

Did you mean 4-space indent here? (We usually do tab, though Meson upstream is 2-space.)

pidgin/tests/test-wrapper.py (Diff revision 1)

The issue has been resolved. Show all issues

'usage: ' should go before the program name?
Also, 'tests' is a bit misleading as it seems like multiple tests are allowed, but really all arguments are run together (i.e., it's [test] [test arguments] or similar.)

grim Nov. 6, 2023, 1:04 a.m.
```
whoops.
```

Change Summary:

address issues

Commits:

	Summary	ID
	Make broadwayd optional for unit testing gtk4-broadwayd isn't packaged for at least homebrew on macOS and maybe others, so this only runs the broadway tests if broadway is found.	5daf17a0b46cf2da7311e5ef22c189a488950972
	Make broadwayd optional for unit testing gtk4-broadwayd isn't packaged for at least homebrew on macOS and maybe others, so this only runs the broadway tests if broadway is found.	cba7e7756a151769044be1f4d79d223a392bdf20

Diff:

Revision 2 (+42 -26)

Show changes

	pidgin/tests/meson.build
	pidgin/tests/test-wrapper.py

Ship it!

```
Ship It!
```

Status:: Completed