Summary

Integrate PurplePresenceManager with the core and uis

Review Request #2771 — Created Nov. 3, 2023 and submitted Nov. 3, 2023, 5:51 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

The original implemenation was just the API and wasn't yet tied into the core
or ui. This fixes that.

Testing Done

Temporarily added code to add a saved status in the PurpleUi->get_presence_manager implementation and verified it was saved to the correct file.

Commits

Summary	ID
Integrate PurplePresenceManager with the core and uis The original implemenation was just the API and wasn't yet tied into the core or ui. This fixes that.	7f2c65583c006647b3cd2ac5318ceadf1b36fd41

Issues

Description	From	Last Updated
Also (nullable)? And maybe should have the same NULL caveat as above?	QuLogic	Nov. 3, 2023, 5:26 a.m.
s/THis/This/	QuLogic	Nov. 3, 2023, 5:26 a.m.
Blank line is usually after g_return... and not the klass = ....	QuLogic	Nov. 3, 2023, 5:26 a.m.

libpurple/purplepresencemanager.h (Diff revision 1)

Show all issues

Also (nullable)? And maybe should have the same NULL caveat as above?

libpurple/purpleui.c (Diff revision 1)

Show all issues

Blank line is usually after g_return... and not the klass = ....

rebased and addressed issues.

	Summary	ID
	Integrate PurplePresenceManager with the core and uis The original implemenation was just the API and wasn't yet tied into the core or ui. This fixes that.	1c6aca276a6aa47e81e6be80448344d1c2e9e5c9
	Integrate PurplePresenceManager with the core and uis The original implemenation was just the API and wasn't yet tied into the core or ui. This fixes that.	7f2c65583c006647b3cd2ac5318ceadf1b36fd41

	libpurple/core.c
	libpurple/meson.build
	libpurple/purplepresencemanager.h
	libpurple/purplepresencemanager.c
	libpurple/purplepresencemanagerprivate.h
	libpurple/purpleui.h
	libpurple/purpleui.c
	pidgin/pidginui.c

Ship it!

Review Board 6.0.2