Summary

Update a bunch of gettext stuff

Review Request #2759 — Created Oct. 31, 2023 and submitted Nov. 3, 2023, 4:52 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add support for a PURPLE_LOCALE_DIR environment variable so we can set the
locale directory in a dev environment.

Added purple_get_locale_dir() which will check the environment variable or
fallback to PURPLE_LOCALE_DIR.

Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with
GETTEXT_PACKAGE which is much more self explanatory.

Testing Done

Compiled with finch enabled and verified no issues.

Commits

Summary	ID
Update a bunch of gettext stuff Add support for a PURPLE_LOCALE_DIR environment variable so we can set the locale directory in a dev environement. Added purple_get_locale_dir() which will check the environement variable or fallback to PURPLE_LOCALE_DIR. Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with GETTEXT_PACKAGE which is much more self explanatory.	0bdf39795afe907951f7bdc4e3124c573003153a

Issues

Description	From	Last Updated
... should be searched ...	QuLogic	Nov. 3, 2023, 4:50 a.m.

Change Summary:

rebased and added the locale path to the runtime directories in the about box.

Commits:

	Summary	ID
	Update a bunch of gettext stuff Add support for a PURPLE_LOCALE_DIR environment variable so we can set the locale directory in a dev environement. Added purple_get_locale_dir() which will check the environement variable or fallback to PURPLE_LOCALE_DIR. Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with GETTEXT_PACKAGE which is much more self explanatory.	31c6015585c6e5eaa94f4a3614b24ee6ea031f9e
	Update a bunch of gettext stuff Add support for a PURPLE_LOCALE_DIR environment variable so we can set the locale directory in a dev environement. Added purple_get_locale_dir() which will check the environement variable or fallback to PURPLE_LOCALE_DIR. Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with GETTEXT_PACKAGE which is much more self explanatory.	1ecefe4fe4ae8e9c4a0ace7f53270d6939db907d

Diff:

Revision 2 (+184 -74)

Show changes

	meson.build
	finch/libfinch.c
	libpurple/core.h
	libpurple/core.c
	libpurple/util.c
	libpurple/protocols/jabber/jabber.c
	pidgin/libpidgin.c
	pidgin/pidginabout.c
	1 more

Ship it!

```
Ship It!
```
libpurple/core.h (Diff revision 2)
Show all issues
```
... should be searched ...
```

Change Summary:

Fix typos.

Description:

		Add support for a PURPLE_LOCALE_DIR environment variable so we can set the
~		locale directory in a dev environement.
	~	locale directory in a dev environment.

~		Added purple_get_locale_dir() which will check the environement variable or
	~	Added purple_get_locale_dir() which will check the environment variable or
		fallback to PURPLE_LOCALE_DIR.

		Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with
		GETTEXT_PACKAGE which is much more self explanatory.

Change Summary:

rebased and addressed the issue.

Commits:

	Summary	ID
	Update a bunch of gettext stuff Add support for a PURPLE_LOCALE_DIR environment variable so we can set the locale directory in a dev environement. Added purple_get_locale_dir() which will check the environement variable or fallback to PURPLE_LOCALE_DIR. Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with GETTEXT_PACKAGE which is much more self explanatory.	1ecefe4fe4ae8e9c4a0ace7f53270d6939db907d
	Update a bunch of gettext stuff Add support for a PURPLE_LOCALE_DIR environment variable so we can set the locale directory in a dev environement. Added purple_get_locale_dir() which will check the environement variable or fallback to PURPLE_LOCALE_DIR. Removed the old PACKAGE and PACKAGE_NAME constants and replaced them with GETTEXT_PACKAGE which is much more self explanatory.	0bdf39795afe907951f7bdc4e3124c573003153a

Diff:

Revision 3 (+184 -74)

Show changes

	meson.build
	finch/libfinch.c
	libpurple/core.h
	libpurple/core.c
	libpurple/util.c
	libpurple/protocols/jabber/jabber.c
	pidgin/libpidgin.c
	pidgin/pidginabout.c
	1 more

Review Board 6.0.2

Update a bunch of gettext stuff

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Description:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

libpurple/core.h (Diff revision 2)