Summary

Remove a whole bunch of dead code from gtkconv.c

Review Request #2748 — Created Oct. 27, 2023 and submitted Oct. 29, 2023, 1:51 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

I opened an IM, a Chat, and a Channel without any of this code.

Testing Done

Consulted the turtles and joined all the things as mentioned above.

Commits

Summary	ID
Remove a whole bunch of dead code from gtkconv.c I opened an IM, a Chat, and a Channel without any of this code.	9dfc4be13bbd7ad4f24de6bb530c82e7202bcd71

Issues

Description	From	Last Updated
Should the removal of these functions go to Changlog.API?	ivanhoe	Oct. 28, 2023, 10:22 a.m.

pidgin/gtkconv.h (Diff revision 1)

Show all issues

Should the removal of these functions go to Changlog.API?

detach was added in 3.0, but yeah attach should be in ChangeLog.API good catch!

update ChangeLog.API

	Summary	ID
	Remove a whole bunch of dead code from gtkconv.c I opened an IM, a Chat, and a Channel without any of this code.	84fc532477f10ab7ab2109c6a7ea103c65e6d022
	Remove a whole bunch of dead code from gtkconv.c I opened an IM, a Chat, and a Channel without any of this code.	9dfc4be13bbd7ad4f24de6bb530c82e7202bcd71

Revision 2 (+10 -1206)

Ship it!

Review Board 6.0.2