Fix inconsistent function export annotations

 






 

 


  Review Request #2740
  —
  Created Oct. 27, 2023 and submitted 

 




















 

  

   Information

  





 
 

  QuLogic
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
The G_DECLARE_*TYPE macros create a function prototype for the _get_type

function, so a second declaration with G_MODULE_EXPORT causes an

inconsistency (which only MSVC seems to complain about.)

 








  


 
 

  
Compiled on Windows, though only Bonjour.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix inconsistent function export annotations
      
The `G_DECLARE_*TYPE` macros create a function prototype for the `_get_type`
function, so a second declaration with `G_MODULE_EXPORT` causes an
inconsistency (which only MSVC seems to complain about.)

     


    		
    692300d15afdfce705befa4b2ef44a993670ac5a

   



  
 




 













 









 






  

 








 














 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Nice find, there's probably more of this somewhere though? Either way thanks!!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...