Summary

Fix inconsistent function export annotations

Review Request #2740 — Created Oct. 27, 2023 and submitted Oct. 27, 2023, 4:14 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The G_DECLARE_*TYPE macros create a function prototype for the _get_type

function, so a second declaration with G_MODULE_EXPORT causes an

inconsistency (which only MSVC seems to complain about.)

Testing Done

Compiled on Windows, though only Bonjour.

Commits

Summary	ID
Fix inconsistent function export annotations The `G_DECLARE_*TYPE` macros create a function prototype for the `_get_type` function, so a second declaration with `G_MODULE_EXPORT` causes an inconsistency (which only MSVC seems to complain about.)	692300d15afdfce705befa4b2ef44a993670ac5a

Expand All
Collapse All

Ship it!

Nice find, there's probably more of this somewhere though? Either way thanks!!

Status:: Completed