Summary

Add a get_history_adapter method to PurpleUi and implement in Pidgin and Finch

Review Request #2738 — Created Oct. 27, 2023 and submitted Oct. 27, 2023, 3:26 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This should simplify the process of starting up the history API as it puts the
work into libpurple which will fallback to an in-memory history adapter if the
UI did not provide one.

Testing Done

Ran the unit tests under valgrind.
Also sent some messages to the echo bot with Pidgin.

Commits

Summary	ID
Add a get_history_adapter method to PurpleUi and implement in Pidgin and Finch This shuold simplify the process of starting up the history API as it puts the work into libpurple which will fallback to an in memory history adapter if the ui did not provide one.	d34320d577eafefe6a900258c635b74b27060164

Issues

Description	From	Last Updated
Do we need to register the weak pointer cleanup for default_manager here?	QuLogic	Oct. 27, 2023, 3:15 a.m.
in-memory	QuLogic	Oct. 27, 2023, 3:15 a.m.

Change Summary:

Fix typos

Description:

~		This shuold simplify the process of starting up the history API as it puts the
~		work into libpurple which will fallback to an in memory history adapter if the
~		ui did not provide one.
	~	This should simplify the process of starting up the history API as it puts the
	~	work into libpurple which will fallback to an in-memory history adapter if the
	~	UI did not provide one.

libpurple/purplehistorymanager.c (Diff revision 1)

Show all issues

Do we need to register the weak pointer cleanup for default_manager here?

grim Oct. 27, 2023, 3:10 a.m.

Oh, this code predates all of that, but we should for sure do that!

libpurple/purpleui.h (Diff revision 1)
Show all issues
```
in-memory
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add a get_history_adapter method to PurpleUi and implement in Pidgin and Finch This shuold simplify the process of starting up the history API as it puts the work into libpurple which will fallback to an in memory history adapter if the ui did not provide one.	c3f49d386945908ca8a3313110b7a7b60c7d6b15
	Add a get_history_adapter method to PurpleUi and implement in Pidgin and Finch This shuold simplify the process of starting up the history API as it puts the work into libpurple which will fallback to an in memory history adapter if the ui did not provide one.	d34320d577eafefe6a900258c635b74b27060164

Diff:

Revision 2 (+274 -326)

Show changes

	finch/finchui.c
	libpurple/core.c
	libpurple/purplehistorymanager.h
	libpurple/purplehistorymanager.c
	libpurple/purpleui.h
	libpurple/purpleui.c
	libpurple/tests/test_ui.c
	pidgin/pidginui.c
	1 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add a get_history_adapter method to PurpleUi and implement in Pidgin and Finch

Information

Reviewers

Change Summary:

Description:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)