Great work! Thanks!!
Also iirc we moved all of the
config.hto source files a long time ago to avoid the same issue for our downstreams.
Fix possible clash of config headers
Review Request #2707 — Created Oct. 25, 2023 and submitted
Both GLib and GStreamer have a config file called
config.hand use the
HAVE_CONFIG_Hmacro to conditionally include them.
Normally, this works out fine, but if they are subprojects, we may accidentally trigger including a different
config.h. This is normally harmless, but it causes a bunch of warnings because we define
GETTEXT_PACKAGEon the command-line, and it won't match the one in a different project.
However, we only include this file in source files, not headers, and it's always created, so there's no need to conditionally include it or define the macro. We can also rename it so it can't clash with other instances as well.
Compiled with subprojects and stopped seeing many warnings about
GETTEXT_PACKAGEand other generic variables being re-defined due to GStreamer's