Add an XScreenSaver based idle source for the new Idle Manager

Review Request #2689 — Created Oct. 24, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Add an XScreenSaver based idle source for the new Idle Manager

Set my xscreensaver blank time to 1 minute and verified it detected it.
Also manually blanked and made sure it detected it.

Summary ID
Add an XScreenSaver based idle source for the new Idle Manager
f2a83eb24819a1c771c72d5f042d49eb48244f00
Description From Last Updated

While testing this, I noticed that there are state changed to unblank messages when launching or restarting the xscreensaver daemon …

ivanhoeivanhoe

Documentation seems to suggest that xevent can be NULL. Maybe there should be a NULL check here?

ivanhoeivanhoe

x_data only free'd in early return.

ivanhoeivanhoe

pluginis not unused.

ivanhoeivanhoe
ivanhoe
  1. 
      
  2. While testing this, I noticed that there are state changed to unblank messages when launching or restarting the xscreensaver daemon via xscreensaver-demo's file menu. Not sure if this is the intended behaviour.

    1. Yeah that should be fine, we lost our source of idle reporting so we can't be idle.

  3. Documentation seems to suggest that xevent can be NULL. Maybe there should be a NULL check here?

  4. x_data only free'd in early return.

  5. pluginis not unused.

  6. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...