Summary

Add an XScreenSaver based idle source for the new Idle Manager

Review Request #2689 — Created Oct. 24, 2023 and submitted Oct. 31, 2023, 8:59 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add an XScreenSaver based idle source for the new Idle Manager

Testing Done

Set my xscreensaver blank time to 1 minute and verified it detected it.
Also manually blanked and made sure it detected it.

Commits

Summary	ID
Add an XScreenSaver based idle source for the new Idle Manager	f2a83eb24819a1c771c72d5f042d49eb48244f00

Issues

Description	From	Last Updated
While testing this, I noticed that there are state changed to unblank messages when launching or restarting the xscreensaver daemon …	ivanhoe	Oct. 31, 2023, 7:16 a.m.
Documentation seems to suggest that xevent can be NULL. Maybe there should be a NULL check here?	ivanhoe	Oct. 31, 2023, 7:17 a.m.
x_data only free'd in early return.	ivanhoe	Oct. 31, 2023, 7:17 a.m.
pluginis not unused.	ivanhoe	Oct. 31, 2023, 7:17 a.m.

The issue has been dropped. Show all issues

While testing this, I noticed that there are state changed to unblank messages when launching or restarting the xscreensaver daemon via xscreensaver-demo's file menu. Not sure if this is the intended behaviour.

grim Oct. 31, 2023, 2:59 a.m.

Yeah that should be fine, we lost our source of idle reporting so we can't be idle.

pidgin/plugins/idle-xscreensaver/idle-xscreensaver.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Documentation seems to suggest that xevent can be NULL. Maybe there should be a NULL check here?
```
pidgin/plugins/idle-xscreensaver/idle-xscreensaver.c (Diff revision 1)
The issue has been resolved. Show all issues
```
x_data only free'd in early return.
```
pidgin/plugins/idle-xscreensaver/idle-xscreensaver.c (Diff revision 1)
The issue has been resolved. Show all issues
```
pluginis not unused.
```

Change Summary:

Rebased and addressed issues.

Commits:

	Summary	ID
	Add an XScreenSaver based idle source for the new Idle Manager	0e8e0970cf20320a387287ab63703db8614bed04
	Add an XScreenSaver based idle source for the new Idle Manager	60cfa21483515e04ae2c9cc657731097c9a30281

Diff:

Revision 2 (+484)

Show changes

	pidgin/plugins/meson.build
	pidgin/plugins/idle-xscreensaver/idle-xscreensaver.c
	pidgin/plugins/idle-xscreensaver/meson.build

Ship it!

```
Ship It!
```

Change Summary:

rebased and moved to PurplePluginInfo and PidginPluginInfo was removed.

Commits:

	Summary	ID
	Add an XScreenSaver based idle source for the new Idle Manager	60cfa21483515e04ae2c9cc657731097c9a30281
	Add an XScreenSaver based idle source for the new Idle Manager	f2a83eb24819a1c771c72d5f042d49eb48244f00

Diff:

Revision 3 (+484)

Show changes

	pidgin/plugins/meson.build
	pidgin/plugins/idle-xscreensaver/idle-xscreensaver.c
	pidgin/plugins/idle-xscreensaver/meson.build

Status:: Completed